RE: [tip:sched/core] sched/cpuacct: Split usage accounting into user_usage and sys_usage

2016-04-06 Thread Zhao Lei
el@vger.kernel.org; t...@kernel.org; > torva...@linux-foundation.org; zhao...@cn.fujitsu.com; > yangds.f...@cn.fujitsu.com; h...@zytor.com; Stephen Rothwell > ; Michael Ellerman > Subject: Re: [tip:sched/core] sched/cpuacct: Split usage accounting into > user_usage and sys_usage >

Re: [tip:sched/core] sched/cpuacct: Split usage accounting into user_usage and sys_usage

2016-04-06 Thread Peter Zijlstra
On Wed, Apr 06, 2016 at 08:32:19PM +1000, Anton Blanchard wrote: > Hi, > > > > > void cpuacct_charge(struct task_struct *tsk, u64 cputime) > > > > { > > > > struct cpuacct *ca; > > > > + int index; > > > > + > > > > + if (user_mode(task_pt_regs(tsk))) > > > > +

Re: [tip:sched/core] sched/cpuacct: Split usage accounting into user_usage and sys_usage

2016-04-06 Thread Anton Blanchard
Hi, > > > void cpuacct_charge(struct task_struct *tsk, u64 cputime) > > > { > > > struct cpuacct *ca; > > > + int index; > > > + > > > + if (user_mode(task_pt_regs(tsk))) > > > + index = CPUACCT_USAGE_USER; > > > + else > > > + index = CPUACCT_USAGE_SYSTEM; This is oopsing bec

Re: [tip:sched/core] sched/cpuacct: Split usage accounting into user_usage and sys_usage

2016-04-06 Thread Peter Zijlstra
On Wed, Apr 06, 2016 at 03:47:18PM +0800, Zhao Lei wrote: > > If you change the above loop to something like: > > > > for (ca = task_ca(tsk); ca; ca = parent_ca(ca)) { > > if (WARN_ON_ONCE(!ca->cpuusage)) > > continue; > > this_cpu_ptr(ca->cpuusage)-

RE: [tip:sched/core] sched/cpuacct: Split usage accounting into user_usage and sys_usage

2016-04-06 Thread Zhao Lei
el@vger.kernel.org; t...@kernel.org; torva...@linux-foundation.org; > zhao...@cn.fujitsu.com; pet...@infradead.org; yangds.f...@cn.fujitsu.com; > h...@zytor.com > Subject: Re: [tip:sched/core] sched/cpuacct: Split usage accounting into > user_usage and sys_usage > > > * Srik

Re: [tip:sched/core] sched/cpuacct: Split usage accounting into user_usage and sys_usage

2016-04-05 Thread Ingo Molnar
* Srikar Dronamraju wrote: > * tip-bot for Dongsheng Yang [2016-03-31 02:27:39]: > > > Commit-ID: d740037fac7052e49450f6fa1454f1144a103b55 > > Gitweb: > > http://git.kernel.org/tip/d740037fac7052e49450f6fa1454f1144a103b55 > > Author: Dongsheng Yang > > AuthorDate: Tue, 22 Mar 2016 1

Re: [tip:sched/core] sched/cpuacct: Split usage accounting into user_usage and sys_usage

2016-04-04 Thread Srikar Dronamraju
* tip-bot for Dongsheng Yang [2016-03-31 02:27:39]: > Commit-ID: d740037fac7052e49450f6fa1454f1144a103b55 > Gitweb: http://git.kernel.org/tip/d740037fac7052e49450f6fa1454f1144a103b55 > Author: Dongsheng Yang > AuthorDate: Tue, 22 Mar 2016 16:37:08 +0800 > Committer: Ingo Molnar > Comm