RE: [virtio-dev] [PATCH] virtio-blk: add DISCARD support to virtio-blk driver

2017-03-27 Thread Liu, Changpeng
ion.org; linux-kernel@vger.kernel.org; > h...@lst.de > Cc: qemu-de...@nongnu.org > Subject: Re: [virtio-dev] [PATCH] virtio-blk: add DISCARD support to > virtio-blk driver > > > > On 28/03/2017 10:39, Changpeng Liu wrote: > > + if (virtio_has_featu

Re: [virtio-dev] [PATCH] virtio-blk: add DISCARD support to virtio-blk driver

2017-03-27 Thread Paolo Bonzini
On 28/03/2017 10:39, Changpeng Liu wrote: > + if (virtio_has_feature(vdev, VIRTIO_BLK_F_DISCARD)) { > + q->limits.discard_zeroes_data = 0; Maybe you could use another feature bit to populate discard_zeroes_data. Paolo > + q->limits.discard_alignment = blk_size; > +