Re: BUG in scsi_lib.c due to a bad commit

2014-11-24 Thread Barto
Hello Christoph, to be clear : my JMicron pcie card JMB363/368 has 2 sata ports and one IDE port, JMicron supports AHCI on these 2 sata ports, my gigabyte motherboard has 4 sata ports and one IDE port, my gigabyte motherboard doesn't support AHCI on these 4 sata ports ( my bios seems to treats

Re: BUG in scsi_lib.c due to a bad commit

2014-11-24 Thread Christoph Hellwig
On Thu, Nov 20, 2014 at 07:27:49PM +0100, Barto wrote: > but the sata DVD burner is now connected on a Jmicron sata PCIe card ( > with this configuration the bug doesn't occur ), I don't know if this > change can modify the result of your command, > > here is the result of another command : > >

Re: BUG in scsi_lib.c due to a bad commit

2014-11-24 Thread Christoph Hellwig
On Thu, Nov 20, 2014 at 07:27:49PM +0100, Barto wrote: but the sata DVD burner is now connected on a Jmicron sata PCIe card ( with this configuration the bug doesn't occur ), I don't know if this change can modify the result of your command, here is the result of another command : $ for i

Re: BUG in scsi_lib.c due to a bad commit

2014-11-24 Thread Barto
Hello Christoph, to be clear : my JMicron pcie card JMB363/368 has 2 sata ports and one IDE port, JMicron supports AHCI on these 2 sata ports, my gigabyte motherboard has 4 sata ports and one IDE port, my gigabyte motherboard doesn't support AHCI on these 4 sata ports ( my bios seems to treats

Re: BUG in scsi_lib.c due to a bad commit

2014-11-20 Thread Barto
Hello, here is the result of the command : $ for i in /sys/class/scsi_host/*; do cat $i/can_queue; done 1 1 1 1 1 1 31 31 but the sata DVD burner is now connected on a Jmicron sata PCIe card ( with this configuration the bug doesn't occur ), I don't know if this change can modify the result of

Re: BUG in scsi_lib.c due to a bad commit

2014-11-20 Thread Christoph Hellwig
On Thu, Nov 20, 2014 at 06:44:32PM +0100, Barto wrote: > I notice that my motherboard doesn't support "AHCI" mode, my motherboard > uses an ICH7 sata controler, ICH7 doesn't support AHCI if I check the > technical specifications of this controler, > > it seems that my bios treats SATA devices

Re: BUG in scsi_lib.c due to a bad commit

2014-11-20 Thread Barto
Hello Christoph, I tested your patch, it works, the bug is gone with your patch, it's a good news, I notice that my motherboard doesn't support "AHCI" mode, my motherboard uses an ICH7 sata controler, ICH7 doesn't support AHCI if I check the technical specifications of this controler, it seems

Re: BUG in scsi_lib.c due to a bad commit

2014-11-20 Thread Barto
Hello Christoph, I tested your patch, it works, the bug is gone with your patch, it's a good news, I notice that my motherboard doesn't support AHCI mode, my motherboard uses an ICH7 sata controler, ICH7 doesn't support AHCI if I check the technical specifications of this controler, it seems

Re: BUG in scsi_lib.c due to a bad commit

2014-11-20 Thread Christoph Hellwig
On Thu, Nov 20, 2014 at 06:44:32PM +0100, Barto wrote: I notice that my motherboard doesn't support AHCI mode, my motherboard uses an ICH7 sata controler, ICH7 doesn't support AHCI if I check the technical specifications of this controler, it seems that my bios treats SATA devices like IDE

Re: BUG in scsi_lib.c due to a bad commit

2014-11-20 Thread Barto
Hello, here is the result of the command : $ for i in /sys/class/scsi_host/*; do cat $i/can_queue; done 1 1 1 1 1 1 31 31 but the sata DVD burner is now connected on a Jmicron sata PCIe card ( with this configuration the bug doesn't occur ), I don't know if this change can modify the result of

Re: BUG in scsi_lib.c due to a bad commit

2014-11-19 Thread Christoph Hellwig
I Hi Barto, sorry for the late reply, and thanks for drilling down the exact conditions. I think we have some issues with the lack of the host lock vs error handling, but I still don't undertand the details. I've got a test patch for you that just adds the host lock back in a few places while

Re: BUG in scsi_lib.c due to a bad commit

2014-11-19 Thread Barto
Hello, I solved the mystery, I found that the element who triggers the bug ( random hang at boot with kernel 3.17 and 3.18 ) is the combination of 3 elements : - the use of a SATA DVD burner ( Liteon iHAS124 C ) on a ICH7 Sata controler - the use of a gigabyte motherboard GA-P31-DSL3 ( bios

Re: BUG in scsi_lib.c due to a bad commit

2014-11-19 Thread Barto
Hello, I solved the mystery, I found that the element who triggers the bug ( random hang at boot with kernel 3.17 and 3.18 ) is the combination of 3 elements : - the use of a SATA DVD burner ( Liteon iHAS124 C ) on a ICH7 Sata controler - the use of a gigabyte motherboard GA-P31-DSL3 ( bios

Re: BUG in scsi_lib.c due to a bad commit

2014-11-19 Thread Christoph Hellwig
I Hi Barto, sorry for the late reply, and thanks for drilling down the exact conditions. I think we have some issues with the lack of the host lock vs error handling, but I still don't undertand the details. I've got a test patch for you that just adds the host lock back in a few places while

Re: BUG in scsi_lib.c due to a bad commit

2014-11-16 Thread Barto
Hello everyone, > Also, SCSI_QUEUE_DELAY seems like an arbitrary magic number; > maybe that value isn't working correctly anymore? this is an excellent remark from Robert Elliot, this gives me an idea : try to set manually a value in the if() statement ( line 1779 in file

Re: BUG in scsi_lib.c due to a bad commit

2014-11-16 Thread Barto
Hello everyone, Also, SCSI_QUEUE_DELAY seems like an arbitrary magic number; maybe that value isn't working correctly anymore? this is an excellent remark from Robert Elliot, this gives me an idea : try to set manually a value in the if() statement ( line 1779 in file /drivers/scsi/scsi_lib.c

Re: BUG in scsi_lib.c due to a bad commit

2014-11-14 Thread Barto
Hello Christoph, I did the new bisect, the first bad commit is : 74665016086615bbaa3fa6f83af410a0a4e029ee scsi: convert host_busy to atomic_t you can find the bisect log here : https://bugzilla.kernel.org/attachment.cgi?id=157621 Le 14/11/2014 08:32, Christoph Hellwig a écrit : > On Thu,

Re: BUG in scsi_lib.c due to a bad commit

2014-11-14 Thread Barto
Hello Christoph, I did the new bisect, the first bad commit is : 74665016086615bbaa3fa6f83af410a0a4e029ee scsi: convert host_busy to atomic_t you can find the bisect log here : https://bugzilla.kernel.org/attachment.cgi?id=157621 Le 14/11/2014 08:32, Christoph Hellwig a écrit : On Thu, Nov

Re: BUG in scsi_lib.c due to a bad commit

2014-11-13 Thread Christoph Hellwig
On Thu, Nov 13, 2014 at 11:55:38PM +0100, Barto wrote: > it's interesting, with this commit > 74665016086615bbaa3fa6f83af410a0a4e029ee I have the bug : > > scsi: convert host_busy to atomic_t : At this point we'll need a bisction between v3.16 as the last good point, and

Re: BUG in scsi_lib.c due to a bad commit

2014-11-13 Thread Barto
Hello Christoph, > Please explicitly test commits: > > 71e75c97f97a9645d25fbf3d8e4165a558f18747 with commit 71e75c97f97a9645d25fbf3d8e4165a558f18747 there is no problem > and > > 74665016086615bbaa3fa6f83af410a0a4e029ee it's interesting, with this commit

Re: BUG in scsi_lib.c due to a bad commit

2014-11-13 Thread Christoph Hellwig
On Thu, Nov 13, 2014 at 06:14:14PM +0100, Barto wrote: > Hello Christoph, > > I tested this commit : > > 7ae65c0f9646c29432b69580b80e08632e6cd813 scsi: convert target_busy to an > atomic_t > >

Re: BUG in scsi_lib.c due to a bad commit

2014-11-13 Thread Barto
Hello Christoph, I tested this commit : 7ae65c0f9646c29432b69580b80e08632e6cd813 scsi: convert target_busy to an atomic_t http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=7ae65c0f9646c29432b69580b80e08632e6cd813 there is no bug, boot process is ok whit this commit,

Re: BUG in scsi_lib.c due to a bad commit

2014-11-13 Thread Barto
I am not sure to understand your request, it's quite confusing, you ask me to revert this commit and see if the bug is gone ? : 74665016086615bbaa3fa6f83af410a0a4e029ee scsi: convert host_busy to atomic_t

Re: BUG in scsi_lib.c due to a bad commit

2014-11-13 Thread Christoph Hellwig
Guenters commit just fixes the inversion from commit 71e75c97f97a9645d25fbf3d8e4165a558f18747 scsi: convert device_busy to atomic_t Can you please test the commit before that: 74665016086615bbaa3fa6f83af410a0a4e029ee scsi: convert host_busy to atomic_t and check if that works for you or not. --

Re: BUG in scsi_lib.c due to a bad commit

2014-11-13 Thread Barto
y, November 12, 2014 9:28 PM >> To: Guenter Roeck; Bjorn Helgaas >> Cc: linux-kernel@vger.kernel.org; linux-s...@vger.kernel.org; Joe >> Perches >> Subject: Re: BUG in scsi_lib.c due to a bad commit >> >> reverting your commit 045065d8a300a37218c is a solution, b

Re: BUG in scsi_lib.c due to a bad commit

2014-11-13 Thread Barto
: linux-kernel@vger.kernel.org; linux-s...@vger.kernel.org; Joe Perches Subject: Re: BUG in scsi_lib.c due to a bad commit reverting your commit 045065d8a300a37218c is a solution, but it's just a temporary solution, it's better to search why your commit can create a random hang on boot

Re: BUG in scsi_lib.c due to a bad commit

2014-11-13 Thread Christoph Hellwig
Guenters commit just fixes the inversion from commit 71e75c97f97a9645d25fbf3d8e4165a558f18747 scsi: convert device_busy to atomic_t Can you please test the commit before that: 74665016086615bbaa3fa6f83af410a0a4e029ee scsi: convert host_busy to atomic_t and check if that works for you or not. --

Re: BUG in scsi_lib.c due to a bad commit

2014-11-13 Thread Barto
I am not sure to understand your request, it's quite confusing, you ask me to revert this commit and see if the bug is gone ? : 74665016086615bbaa3fa6f83af410a0a4e029ee scsi: convert host_busy to atomic_t

Re: BUG in scsi_lib.c due to a bad commit

2014-11-13 Thread Barto
Hello Christoph, I tested this commit : 7ae65c0f9646c29432b69580b80e08632e6cd813 scsi: convert target_busy to an atomic_t http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=7ae65c0f9646c29432b69580b80e08632e6cd813 there is no bug, boot process is ok whit this commit,

Re: BUG in scsi_lib.c due to a bad commit

2014-11-13 Thread Christoph Hellwig
On Thu, Nov 13, 2014 at 06:14:14PM +0100, Barto wrote: Hello Christoph, I tested this commit : 7ae65c0f9646c29432b69580b80e08632e6cd813 scsi: convert target_busy to an atomic_t

Re: BUG in scsi_lib.c due to a bad commit

2014-11-13 Thread Barto
Hello Christoph, Please explicitly test commits: 71e75c97f97a9645d25fbf3d8e4165a558f18747 with commit 71e75c97f97a9645d25fbf3d8e4165a558f18747 there is no problem and 74665016086615bbaa3fa6f83af410a0a4e029ee it's interesting, with this commit 74665016086615bbaa3fa6f83af410a0a4e029ee I

Re: BUG in scsi_lib.c due to a bad commit

2014-11-13 Thread Christoph Hellwig
On Thu, Nov 13, 2014 at 11:55:38PM +0100, Barto wrote: it's interesting, with this commit 74665016086615bbaa3fa6f83af410a0a4e029ee I have the bug : scsi: convert host_busy to atomic_t : At this point we'll need a bisction between v3.16 as the last good point, and

RE: BUG in scsi_lib.c due to a bad commit

2014-11-12 Thread Elliott, Robert (Server Storage)
org; Joe > Perches > Subject: Re: BUG in scsi_lib.c due to a bad commit > > reverting your commit 045065d8a300a37218c is a solution, but it's just a > temporary solution, > > it's better to search why your commit can create a random hang on boot > on some PC configurations,

Re: BUG in scsi_lib.c due to a bad commit

2014-11-12 Thread Barto
reverting your commit 045065d8a300a37218c is a solution, but it's just a temporary solution, it's better to search why your commit can create a random hang on boot on some PC configurations, --- a/drivers/scsi/scsi_lib.c +++ b/drivers/scsi/scsi_lib.c @@ -1774,7 +1774,7 @@ static void

Re: BUG in scsi_lib.c due to a bad commit

2014-11-12 Thread Barto
reverting your commit 045065d8a300a37218c is a solution, but it's just a temporary solution, it's better to search why your commit can create a random hang on boot on some PC configurations, --- a/drivers/scsi/scsi_lib.c +++ b/drivers/scsi/scsi_lib.c @@ -1774,7 +1774,7 @@ static void

RE: BUG in scsi_lib.c due to a bad commit

2014-11-12 Thread Elliott, Robert (Server Storage)
Subject: Re: BUG in scsi_lib.c due to a bad commit reverting your commit 045065d8a300a37218c is a solution, but it's just a temporary solution, it's better to search why your commit can create a random hang on boot on some PC configurations, --- a/drivers/scsi/scsi_lib.c +++ b/drivers/scsi

Re: BUG in scsi_lib.c due to a bad commit

2014-11-11 Thread Guenter Roeck
On 11/11/2014 04:17 PM, Bjorn Helgaas wrote: [+cc Guenter, linux-scsi] On Tue, Nov 11, 2014 at 4:33 PM, Barto wrote: Hello everyone, I notice a bug since kernel 3.17 ( and also with 3.18 branch ), a random hang at boot on some PC configurations, I did a "git bisect" and I found that the

Re: BUG in scsi_lib.c due to a bad commit

2014-11-11 Thread Bjorn Helgaas
[+cc Guenter, linux-scsi] On Tue, Nov 11, 2014 at 4:33 PM, Barto wrote: > Hello everyone, > > I notice a bug since kernel 3.17 ( and also with 3.18 branch ), a random > hang at boot on some PC configurations, I did a "git bisect" and I found > that the culprit is : > >

Re: BUG in scsi_lib.c due to a bad commit

2014-11-11 Thread Bjorn Helgaas
[+cc Guenter, linux-scsi] On Tue, Nov 11, 2014 at 4:33 PM, Barto mister.free...@laposte.net wrote: Hello everyone, I notice a bug since kernel 3.17 ( and also with 3.18 branch ), a random hang at boot on some PC configurations, I did a git bisect and I found that the culprit is :

Re: BUG in scsi_lib.c due to a bad commit

2014-11-11 Thread Guenter Roeck
On 11/11/2014 04:17 PM, Bjorn Helgaas wrote: [+cc Guenter, linux-scsi] On Tue, Nov 11, 2014 at 4:33 PM, Barto mister.free...@laposte.net wrote: Hello everyone, I notice a bug since kernel 3.17 ( and also with 3.18 branch ), a random hang at boot on some PC configurations, I did a git bisect