RE: Bad Reference Semantics in PIDs Controller.

2015-08-23 Thread Aleksa Sarai
It turns out that, actually, the can_attach(), cancel_attach() and attach() code is broken -- we're incrementing a ref on the old_css of a task in can_attach(). Then we decrement the ref on a *different* css (because the task has been migrated). This is clearly a bad thing. Should we make

RE: Bad Reference Semantics in PIDs Controller.

2015-08-23 Thread Aleksa Sarai
It turns out that, actually, the can_attach(), cancel_attach() and attach() code is broken -- we're incrementing a ref on the old_css of a task in can_attach(). Then we decrement the ref on a *different* css (because the task has been migrated). This is clearly a bad thing. Should we make