RE: Patch for Apani Nortel VPN Client to build against kernel 2.6.22 help/review

2007-09-11 Thread Fortier,Vincent [Montreal]
> -Message d'origine- > De : [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] De la part de Nick Bowler > > I haven't read too much into the patch, but some quick > comments. Most applies > throughout: > > > +#if (LINUX_VERSION_CODE >= 0x020616) > KERNEL_VERSION(2,6,22) is much more reada

Re: Patch for Apani Nortel VPN Client to build against kernel 2.6.22 help/review

2007-08-22 Thread Nick Bowler
I haven't read too much into the patch, but some quick comments. Most applies throughout: > +#if (LINUX_VERSION_CODE >= 0x020616) KERNEL_VERSION(2,6,22) is much more readable than 0x020616. > + return (struct iphdr*) skb->network_header; Should be return ip_hdr(skb); > +skb->network_header