RE: Regression caused by using node_to_bdi()

2015-04-14 Thread Zhao Lei
Hi, Christoph > -Original Message- > From: 'Christoph Hellwig' [mailto:h...@lst.de] > Sent: Tuesday, April 14, 2015 1:33 AM > To: Zhao Lei > Cc: 'Christoph Hellwig'; linux-fsde...@vger.kernel.org; 'Jan Kara'; 'Jens > Axboe'; >

RE: Regression caused by using node_to_bdi()

2015-04-14 Thread Zhao Lei
Hi, Boaz > -Original Message- > From: Boaz Harrosh [mailto:b...@plexistor.com] > Sent: Monday, April 13, 2015 8:31 PM > To: Zhao Lei; 'Boaz Harrosh'; 'Christoph Hellwig' > Cc: linux-fsde...@vger.kernel.org; 'Jan Kara'; 'Jens Axboe&

Re: Regression caused by using node_to_bdi()

2015-04-13 Thread 'Christoph Hellwig'
Tejun posted a series last week that moves node_to_bdi back inline to -fsdevel. Can you apply patches 1-18 of the series "[PATCHSET 1/3 v3 block/for-4.1/core] writeback: cgroup writeback support" and see if that helps your benchmark? -- To unsubscribe from this list: send the line "unsubscribe l

Re: Regression caused by using node_to_bdi()

2015-04-13 Thread Boaz Harrosh
On 04/13/2015 03:21 PM, Jan Kara wrote: <> >> -struct backing_dev_info *inode_to_bdi(struct inode *inode); >> +struct backing_dev_info *__inode_to_bdi(struct inode *inode); >> + >> +static inline >> +struct backing_dev_info *inode_to_bdi(struct inode *inode) >> +{ >> +if (!inode || !inode->i_sb

Re: Regression caused by using node_to_bdi()

2015-04-13 Thread Boaz Harrosh
On 04/13/2015 01:22 PM, Zhao Lei wrote: <> > A new bad news: > This patch make filesystem unstable. > Rrrr yes sorry Lei. Why this boots my systems is not clear this is not what I intended to write. Here is what I meant to write (replacing the old one): diff --git a/fs/fs-writeback.c b/fs/f

Re: Regression caused by using node_to_bdi()

2015-04-13 Thread Jan Kara
On Sun 12-04-15 14:33:12, Boaz Harrosh wrote: > On 04/10/2015 02:25 PM, Zhao Lei wrote: > > Hi, Christoph Hellwig > > > > resend: + cc lkml, linux-fsdevel > > > > Since there is no response for my last mail, I worry that some problem in > > the mail system, please allow me to resend it. > > > >

RE: Regression caused by using node_to_bdi()

2015-04-13 Thread Zhao Lei
Hi, Boaz > -Original Message- > From: Zhao Lei [mailto:zhao...@cn.fujitsu.com] > Sent: Monday, April 13, 2015 3:00 PM > To: 'Boaz Harrosh'; 'Christoph Hellwig' > Cc: 'linux-fsde...@vger.kernel.org'; 'Jan Kara'; 'Jens Axboe&#x

RE: Regression caused by using node_to_bdi()

2015-04-13 Thread Zhao Lei
Hi, Boaz > -Original Message- > From: Boaz Harrosh [mailto:b...@plexistor.com] > Sent: Sunday, April 12, 2015 10:39 PM > To: Boaz Harrosh; Zhao Lei; 'Christoph Hellwig' > Cc: linux-fsde...@vger.kernel.org; 'Jan Kara'; 'Jens Axboe'; &#x

RE: Regression caused by using node_to_bdi()

2015-04-12 Thread Zhao Lei
Hi, Boaz > -Original Message- > From: Boaz Harrosh [mailto:b...@plexistor.com] > Sent: Sunday, April 12, 2015 10:39 PM > To: Boaz Harrosh; Zhao Lei; 'Christoph Hellwig' > Cc: linux-fsde...@vger.kernel.org; 'Jan Kara'; 'Jens Axboe'; &#x

Re: Regression caused by using node_to_bdi()

2015-04-12 Thread Boaz Harrosh
On 04/12/2015 02:33 PM, Boaz Harrosh wrote: > On 04/10/2015 02:25 PM, Zhao Lei wrote: >> Hi, Christoph Hellwig >> <> >> >> Is there some way to speed up it(inline, or some access some variant >> in struct directly, ...)? >> > > Christoph hi > > Both node_to_bdi() and sb_is_blkdev_sb() > (and I_

Re: Regression caused by using node_to_bdi()

2015-04-12 Thread Boaz Harrosh
On 04/10/2015 02:25 PM, Zhao Lei wrote: > Hi, Christoph Hellwig > > resend: + cc lkml, linux-fsdevel > > Since there is no response for my last mail, I worry that some problem in > the mail system, please allow me to resend it. > > I found regression in v4.0-rc1 caused by this patch: > Author:

RE: Regression caused by using node_to_bdi()

2015-04-01 Thread Zhao Lei
Hi, Christoph *From: Zhao Lei [mailto:zhao...@cn.fujitsu.com] > Sent: Monday, March 09, 2015 10:47 AM > To: 'Christoph Hellwig'; 'Jan Kara' > Cc: 'Tejun Heo'; 'Jens Axboe' > Subject: RE: Regression caused by using node_to_bdi() > > Hi, Ch