Re: ipv4: Use standard iovec primitive in raw_probe_proto_opt

2014-11-27 Thread Al Viro
On Thu, Nov 06, 2014 at 10:16:08PM +, Al Viro wrote: > On Thu, Nov 06, 2014 at 09:55:31AM +, Jon Maloy wrote: > > > Point, but that might very well be a pattern to watch for - there's at > > > least one > > > more instance in TIPC (also not exploitable, according to TIPC folks) and > > >

Re: ipv4: Use standard iovec primitive in raw_probe_proto_opt

2014-11-06 Thread Herbert Xu
On Thu, Nov 06, 2014 at 04:28:08PM -0500, David Miller wrote: > From: Herbert Xu > Date: Thu, 6 Nov 2014 14:46:29 +0800 > > > On Thu, Nov 06, 2014 at 06:43:18AM +, Al Viro wrote: > >> On Thu, Nov 06, 2014 at 01:50:23PM +0800, Herbert Xu wrote: > >> > +/* We only need the first two byt

Re: ipv4: Use standard iovec primitive in raw_probe_proto_opt

2014-11-06 Thread Al Viro
On Thu, Nov 06, 2014 at 09:55:31AM +, Jon Maloy wrote: > > Point, but that might very well be a pattern to watch for - there's at > > least one > > more instance in TIPC (also not exploitable, according to TIPC folks) and > > such > > I don't recall this, and I can't see where it would be ei

Re: ipv4: Use standard iovec primitive in raw_probe_proto_opt

2014-11-06 Thread David Miller
From: Herbert Xu Date: Thu, 6 Nov 2014 14:46:29 +0800 > On Thu, Nov 06, 2014 at 06:43:18AM +, Al Viro wrote: >> On Thu, Nov 06, 2014 at 01:50:23PM +0800, Herbert Xu wrote: >> > + /* We only need the first two bytes. */ >> > + err = memcpy_fromiovecend((void *)&icmph, msg->msg_iov, 0, 2); >>

RE: ipv4: Use standard iovec primitive in raw_probe_proto_opt

2014-11-06 Thread Jon Maloy
ide Nakamura; Hideaki YOSHIFUJI > Subject: Re: ipv4: Use standard iovec primitive in raw_probe_proto_opt > > On Thu, Nov 06, 2014 at 02:46:29PM +0800, Herbert Xu wrote: > > On Thu, Nov 06, 2014 at 06:43:18AM +, Al Viro wrote: > > > On Thu, Nov 06, 2014 at 01:50:23PM +0800,

Re: ipv4: Use standard iovec primitive in raw_probe_proto_opt

2014-11-05 Thread Al Viro
On Thu, Nov 06, 2014 at 02:46:29PM +0800, Herbert Xu wrote: > On Thu, Nov 06, 2014 at 06:43:18AM +, Al Viro wrote: > > On Thu, Nov 06, 2014 at 01:50:23PM +0800, Herbert Xu wrote: > > > + /* We only need the first two bytes. */ > > > + err = memcpy_fromiovecend((void *)&icmph, msg->msg_iov, 0, 2

Re: ipv4: Use standard iovec primitive in raw_probe_proto_opt

2014-11-05 Thread Herbert Xu
On Thu, Nov 06, 2014 at 06:43:18AM +, Al Viro wrote: > On Thu, Nov 06, 2014 at 01:50:23PM +0800, Herbert Xu wrote: > > + /* We only need the first two bytes. */ > > + err = memcpy_fromiovecend((void *)&icmph, msg->msg_iov, 0, 2); > > + if (err) > > + return err; > > + > > + fl

Re: ipv4: Use standard iovec primitive in raw_probe_proto_opt

2014-11-05 Thread Al Viro
On Thu, Nov 06, 2014 at 01:50:23PM +0800, Herbert Xu wrote: > + /* We only need the first two bytes. */ > + err = memcpy_fromiovecend((void *)&icmph, msg->msg_iov, 0, 2); > + if (err) > + return err; > + > + fl4->fl4_icmp_type = icmph.type; > + fl4->fl4_icmp_code = i