Re: rtsx_pci not restoring ASPM state after suspend/resume

2020-08-02 Thread James Ettle
Hello, On Tue, 2020-07-28 at 18:06 -0500, Bjorn Helgaas wrote: > > I tried to deduce the problem from the code in aspm.c, but I didn't > see the problem. If you have the ability to build a kernel with a > debug patch, can you boot with the patch below and collect the dmesg > log? I've built

Re: rtsx_pci not restoring ASPM state after suspend/resume

2020-07-28 Thread Bjorn Helgaas
On Tue, Jul 28, 2020 at 09:57:55PM +0100, James Ettle wrote: > On Mon, 2020-07-27 at 16:47 -0500, Bjorn Helgaas wrote: > > > > I don't see anything in rtsx that enables L0s. Can you collect > > the dmesg log when booting with "pci=earlydump"? That will show > > whether the BIOS left it this

Re: rtsx_pci not restoring ASPM state after suspend/resume

2020-07-28 Thread James Ettle
On Mon, 2020-07-27 at 16:47 -0500, Bjorn Helgaas wrote: > > I don't see anything in rtsx that enables L0s. Can you collect the > dmesg log when booting with "pci=earlydump"? That will show whether > the BIOS left it this way. The PCI core isn't supposed to do this, > so > if it did, we need to

RE: rtsx_pci not restoring ASPM state after suspend/resume

2020-07-27 Thread 吳昊澄 Ricky
> On Mon, Jul 27, 2020 at 08:52:25PM +0100, James Ettle wrote: > > On Mon, 2020-07-27 at 09:14 -0500, Bjorn Helgaas wrote: > > > I don't know the connection between ASPM and package C-states, so I > > > need to simplify this even more. All I want to do right now is > > > verify > > > that if we

Re: rtsx_pci not restoring ASPM state after suspend/resume

2020-07-27 Thread Bjorn Helgaas
On Mon, Jul 27, 2020 at 08:52:25PM +0100, James Ettle wrote: > On Mon, 2020-07-27 at 09:14 -0500, Bjorn Helgaas wrote: > > I don't know the connection between ASPM and package C-states, so I > > need to simplify this even more. All I want to do right now is > > verify > > that if we don't have

Re: rtsx_pci not restoring ASPM state after suspend/resume

2020-07-27 Thread James Ettle
On Mon, 2020-07-27 at 09:14 -0500, Bjorn Helgaas wrote: > I don't know the connection between ASPM and package C-states, so I > need to simplify this even more. All I want to do right now is > verify > that if we don't have any outside influences on the ASPM > configuration > (eg, no manual

Re: rtsx_pci not restoring ASPM state after suspend/resume

2020-07-27 Thread Bjorn Helgaas
On Sat, Jul 25, 2020 at 09:27:11PM +0100, James Ettle wrote: > On Fri, 2020-07-24 at 18:13 -0500, Bjorn Helgaas wrote: > > > > Maybe we should simplify this a little bit more. James, if you don't > > touch ASPM config at all, either manually or via udev, does the ASPM > > configuration stay the

Re: rtsx_pci not restoring ASPM state after suspend/resume

2020-07-25 Thread James Ettle
On Fri, 2020-07-24 at 18:13 -0500, Bjorn Helgaas wrote: > > Maybe we should simplify this a little bit more. James, if you don't > touch ASPM config at all, either manually or via udev, does the ASPM > configuration stay the same across suspend/resume? > Yes, it stays the same. Explicitly:

Re: rtsx_pci not restoring ASPM state after suspend/resume

2020-07-24 Thread Bjorn Helgaas
rg; linux-kernel@vger.kernel.org; Jacopo De > > Simoi > > Subject: Re: rtsx_pci not restoring ASPM state after suspend/resume > > > > [+cc Jacopo] > > > > On Thu, Jul 23, 2020 at 11:56:22AM -0500, Bjorn Helgaas wrote: > > > James reported this iss

RE: rtsx_pci not restoring ASPM state after suspend/resume

2020-07-24 Thread 吳昊澄 Ricky
g Kroah-Hartman; James Ettle; Len Brown; Puranjay > Mohan; linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; Jacopo De > Simoi > Subject: Re: rtsx_pci not restoring ASPM state after suspend/resume > > [+cc Jacopo] > > On Thu, Jul 23, 2020 at 11:56:22AM -0500, Bjorn Helgaas

Re: rtsx_pci not restoring ASPM state after suspend/resume

2020-07-23 Thread Bjorn Helgaas
[+cc Jacopo] On Thu, Jul 23, 2020 at 11:56:22AM -0500, Bjorn Helgaas wrote: > James reported this issue with rtsx_pci; can you guys please take a > look at it? https://bugzilla.kernel.org/show_bug.cgi?id=208117 > > There's a lot of good info in the bugzilla already. Likely duplicate: