Re: RFC: MEDIA: Driver for ON Semi AR0521 camera sensor

2021-03-30 Thread Krzysztof Hałasa
Laurent, There is an additional issue: >> +static const struct v4l2_subdev_video_ops ar0521_video_ops = { >> +.g_frame_interval = ar0521_g_frame_interval, >> +.s_frame_interval = ar0521_s_frame_interval, > > For raw sensors, frame intervals should be configured using > V4L2_CID_HBLANK and

Re: RFC: MEDIA: Driver for ON Semi AR0521 camera sensor

2021-03-16 Thread Krzysztof Hałasa
Laurent Pinchart writes: >> Is there a reliable way to include national unicode characters in the >> kernel sources? > > It depends where. In comments it shouldn't be a problem. In C code, I > don't think the compiler will be too happy. I meant in comments, sure. And in stuff like MODULE_AUTHOR.

Re: RFC: MEDIA: Driver for ON Semi AR0521 camera sensor

2021-03-16 Thread Laurent Pinchart
Hi Krzysztof, Thank you for the patch. On Tue, Mar 16, 2021 at 02:25:12PM +0100, Krzysztof Hałasa wrote: > Is there a reliable way to include national unicode characters in the > kernel sources? It depends where. In comments it shouldn't be a problem. In C code, I don't think the compiler will b

RFC: MEDIA: Driver for ON Semi AR0521 camera sensor

2021-03-16 Thread Krzysztof Hałasa
Is there a reliable way to include national unicode characters in the kernel sources? For review only. This will be signed off when (if) the driver is accepted. diff --git a/MAINTAINERS b/MAINTAINERS index bfc1b86e3e73..20514c00909b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1294,6 +1294,12 @