Re: RFC: big ac97_codec audio update

2000-10-19 Thread Jeff Garzik
Rui Sousa wrote: > How about keeping master volume to 0 while you mess up the other > registers? Not a bad idea. 0x8000, so it's muted as well as volume 0. > And it's not a scaling problem? (wrong number of precision bits) It might be scaling bug, but I'm pretty certain the number of precision

Re: RFC: big ac97_codec audio update

2000-10-19 Thread Rui Sousa
On Thu, 19 Oct 2000, Jeff Garzik wrote: > Rui Sousa wrote: > > On Thu, 19 Oct 2000, Jeff Garzik wrote: > > > We need the dynamic bit resolution detection. > > > Isn't this producing noise/pops? (since you maximize the volume). > > During audio init I hear pops, but then again I heard pops durin

Re: RFC: big ac97_codec audio update

2000-10-19 Thread Jeff Garzik
Rui Sousa wrote: > On Thu, 19 Oct 2000, Jeff Garzik wrote: > > We need the dynamic bit resolution detection. > Isn't this producing noise/pops? (since you maximize the volume). During audio init I hear pops, but then again I heard pops during audio init before these changes too :) > > Judging

Re: RFC: big ac97_codec audio update

2000-10-19 Thread Rui Sousa
On Thu, 19 Oct 2000, Jeff Garzik wrote: > It's a big update, but I think it is necessary. > We need the new codec-specific init functions. > We need the new ac97-valid-reg checking. > We need the dynamic bit resolution detection. Isn't this producing noise/pops? (since you maximize the volume).

RFC: big ac97_codec audio update

2000-10-19 Thread Jeff Garzik
It's a big update, but I think it is necessary. We need the new codec-specific init functions. We need the new ac97-valid-reg checking. We need the dynamic bit resolution detection. Full change description, and tested patch against 2.4.0-test10-pre4, follows. This includes some interface changes