Re: RFC (v2): Intel QST sensor driver

2013-03-19 Thread Guenter Roeck
On Tue, Mar 19, 2013 at 09:46:43PM +, Simon J. Rowe wrote: > On 19/03/13 00:27, Guenter Roeck wrote: > >Couple of problems I noticed when browsing through the code. > > > >- Some functions return errors with return code 0. > > > > if (ret <= 0) > > goto out; > > ... > >out:

Re: RFC (v2): Intel QST sensor driver

2013-03-19 Thread Simon J. Rowe
On 19/03/13 00:27, Guenter Roeck wrote: Couple of problems I noticed when browsing through the code. - Some functions return errors with return code 0. if (ret <= 0) goto out; ... out: return ret; For values of 0, the calling code will likely miss

Re: RFC (v2): Intel QST sensor driver

2013-03-19 Thread Simon J. Rowe
On 19/03/13 00:27, Guenter Roeck wrote: Couple of problems I noticed when browsing through the code. - Some functions return errors with return code 0. if (ret = 0) goto out; ... out: return ret; For values of 0, the calling code will likely miss the

Re: RFC (v2): Intel QST sensor driver

2013-03-19 Thread Guenter Roeck
On Tue, Mar 19, 2013 at 09:46:43PM +, Simon J. Rowe wrote: On 19/03/13 00:27, Guenter Roeck wrote: Couple of problems I noticed when browsing through the code. - Some functions return errors with return code 0. if (ret = 0) goto out; ... out: return ret;

Re: RFC (v2): Intel QST sensor driver

2013-03-18 Thread Guenter Roeck
Hi Simon, On Mon, Mar 18, 2013 at 09:20:53PM +, Simon J. Rowe wrote: > Hello, > > I've made changes to my driver for the Intel Quiet System Technology > (QST) function that I posted at the end of last year and would again > appreciate feedback on it. > > As before the git repo can be found

RFC (v2): Intel QST sensor driver

2013-03-18 Thread Simon J. Rowe
Hello, I've made changes to my driver for the Intel Quiet System Technology (QST) function that I posted at the end of last year and would again appreciate feedback on it. As before the git repo can be found here: http://mose.dyndns.org/mei.git Changes from v1 --- The module

RFC (v2): Intel QST sensor driver

2013-03-18 Thread Simon J. Rowe
Hello, I've made changes to my driver for the Intel Quiet System Technology (QST) function that I posted at the end of last year and would again appreciate feedback on it. As before the git repo can be found here: http://mose.dyndns.org/mei.git Changes from v1 --- The module

Re: RFC (v2): Intel QST sensor driver

2013-03-18 Thread Guenter Roeck
Hi Simon, On Mon, Mar 18, 2013 at 09:20:53PM +, Simon J. Rowe wrote: Hello, I've made changes to my driver for the Intel Quiet System Technology (QST) function that I posted at the end of last year and would again appreciate feedback on it. As before the git repo can be found here: