Re: [2.6 patch] kernel/taskstats.c: fix bogus nlmsg_free()

2007-10-26 Thread Balbir Singh
Adrian Bunk wrote: > I considered it more odd to read > > > rc = cgroupstats_build(stats, file->f_dentry); > if (rc < 0) > goto err; > > fput_light(file, fput_needed); > return send_reply(rep_skb, info->snd_p

Re: [2.6 patch] kernel/taskstats.c: fix bogus nlmsg_free()

2007-10-24 Thread Balbir Singh
Adrian Bunk wrote: > We'd better not nlmsg_free on a pointer containing an undefined value > (and without having anything allocated)... > > Spotted by the Coverity checker. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > --- > > kernel/taskstats.c | 12 ++-- > 1 file changed,