Re: [31/37] Large blocksize support: Core piece

2007-06-20 Thread Christoph Lameter
On Wed, 20 Jun 2007, Bob Picco wrote: > > + if (size > (PAGE_SIZE << MAX_ORDER) || size < 512 || > > + !is_power_of_2(size)) > I think this should be: > if (size > (MAX_ORDER_NR_PAGES << PAGE_SHIFT) ... > or > if (size > (PAGE_SIZE <<

Re: [31/37] Large blocksize support: Core piece

2007-06-20 Thread Bob Picco
Christoph Lameter wrote:[Wed Jun 20 2007, 02:29:38PM EDT] > Provide an alternate definition for the page_cache_xxx(mapping, ...) > functions that can determine the current page size from the mapping > and generate the appropriate shifts, sizes and mask for the page cache > operations. Chang