Re: [BUG REPORT] use of unreachable() masks uninitialized variables warnings

2016-02-11 Thread Jeff Merkey
On 2/11/16, Theodore Ts'o wrote: > On Thu, Feb 11, 2016 at 11:12:12AM -0700, Jeff Merkey wrote: >> >> That's good to know, they could be false positives, but it was kind of >> wierd behavior caused by that macro. > > If it is true, it sounds more like a compiler bug to me. Any > statements a BUG(

Re: [BUG REPORT] use of unreachable() masks uninitialized variables warnings

2016-02-11 Thread Jeff Merkey
On 2/11/16, Jeff Merkey wrote: >> In your case, for example, I looked through several dozen warnings, >> and they were ***all*** bogus. Keep in mind that this might make me >> less inclined to pay attention to complaints from you in the future. >> The story of the buy who cried wolf too often com

Re: [BUG REPORT] use of unreachable() masks uninitialized variables warnings

2016-02-11 Thread Jeff Merkey
> In your case, for example, I looked through several dozen warnings, > and they were ***all*** bogus. Keep in mind that this might make me > less inclined to pay attention to complaints from you in the future. > The story of the buy who cried wolf too often comes to mind. > > Perhaps you could ac

Re: [BUG REPORT] use of unreachable() masks uninitialized variables warnings

2016-02-11 Thread Jeff Merkey
On 2/11/16, Theodore Ts'o wrote: > On Thu, Feb 11, 2016 at 11:12:12AM -0700, Jeff Merkey wrote: >> >> That's good to know, they could be false positives, but it was kind of >> wierd behavior caused by that macro. > > If it is true, it sounds more like a compiler bug to me. Any > statements a BUG(

Re: [BUG REPORT] use of unreachable() masks uninitialized variables warnings

2016-02-11 Thread Theodore Ts'o
On Thu, Feb 11, 2016 at 11:12:12AM -0700, Jeff Merkey wrote: > > That's good to know, they could be false positives, but it was kind of > wierd behavior caused by that macro. If it is true, it sounds more like a compiler bug to me. Any statements a BUG() call are unreachable. If the compiler as

Re: [BUG REPORT] use of unreachable() masks uninitialized variables warnings

2016-02-11 Thread Jeff Merkey
On 2/11/16, Theodore Ts'o wrote: > On Wed, Feb 10, 2016 at 08:13:09PM -0700, Jeff Merkey wrote: >> Here are the sources of several bugs I have seen recently in ext4 I am >> pretty sure with a null bh. One good check is to set the BUG() macro >> NOT TO call unreachable() as a build test since the

Re: [BUG REPORT] use of unreachable() masks uninitialized variables warnings

2016-02-11 Thread Theodore Ts'o
On Wed, Feb 10, 2016 at 08:13:09PM -0700, Jeff Merkey wrote: > Here are the sources of several bugs I have seen recently in ext4 I am > pretty sure with a null bh. One good check is to set the BUG() macro > NOT TO call unreachable() as a build test since the compiler will > ignore uninitialized va