Re: [BUGFIX PATCH -tip] kprobes/x86: Fix to copy RIP relative instruction correctly

2018-12-04 Thread Masami Hiramatsu
On Tue, 4 Dec 2018 09:13:35 +0100 Ingo Molnar wrote: > > * Masami Hiramatsu wrote: > > > Since copy_optimized_instructions() misses to update real RIP > > address while copying several instructions to working buffer, > > it adjusts RIP-relative instruction with wrong RIP address for > > the 2n

Re: [BUGFIX PATCH -tip] kprobes/x86: Fix to copy RIP relative instruction correctly

2018-12-04 Thread Ingo Molnar
* Masami Hiramatsu wrote: > Since copy_optimized_instructions() misses to update real RIP > address while copying several instructions to working buffer, > it adjusts RIP-relative instruction with wrong RIP address for > the 2nd and subsequent instructions. > > This may break the kernel (like

Re: [BUGFIX PATCH -tip] kprobes/x86: Fix to copy RIP relative instruction correctly

2018-09-02 Thread Masami Hiramatsu
Hi Ingo, Could you pick this fix to urgent branch? Thank you, On Fri, 24 Aug 2018 16:57:19 +0900 Masami Hiramatsu wrote: > On Thu, 23 Aug 2018 21:41:09 -0400 > Steven Rostedt wrote: > > > On Fri, 24 Aug 2018 02:16:12 +0900 > > Masami Hiramatsu wrote: > > > > > Dump of assembler code from 0

Re: [BUGFIX PATCH -tip] kprobes/x86: Fix to copy RIP relative instruction correctly

2018-08-24 Thread Masami Hiramatsu
On Thu, 23 Aug 2018 21:41:09 -0400 Steven Rostedt wrote: > On Fri, 24 Aug 2018 02:16:12 +0900 > Masami Hiramatsu wrote: > > > Dump of assembler code from 0xa000207a to 0xa00020ea: > > 54 push %rsp > > ... > > 48 83 c4 08 add$0x8,%rsp > > 9d popfq

Re: [BUGFIX PATCH -tip] kprobes/x86: Fix to copy RIP relative instruction correctly

2018-08-23 Thread Steven Rostedt
On Fri, 24 Aug 2018 02:16:12 +0900 Masami Hiramatsu wrote: > Dump of assembler code from 0xa000207a to 0xa00020ea: > 54 push %rsp > ... > 48 83 c4 08 add$0x8,%rsp > 9d popfq > 48 89 f0mov%rsi,%rax > 8b 35 82 7d db e2