Re: [GIT PULL] Please pull NFS client changes for 5.11

2020-12-17 Thread Trond Myklebust
On Thu, 2020-12-17 at 12:25 -0800, Linus Torvalds wrote: > On Thu, Dec 17, 2020 at 10:05 AM Trond Myklebust > wrote: > > > >   git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs- > > for- > > 5.11-1 > > > > for you to fetch changes up to > > 52104f274e2d7f134d34bab11cada8913d4544e2:

Re: [GIT PULL] Please pull NFS client changes for 5.11

2020-12-17 Thread Linus Torvalds
On Thu, Dec 17, 2020 at 10:05 AM Trond Myklebust wrote: > > git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for- > 5.11-1 > > for you to fetch changes up to > 52104f274e2d7f134d34bab11cada8913d4544e2: pr-tracker-bot doesn't seem to have reacted to this email. I suspect it's bec

Re: [GIT PULL] Please pull NFS client changes

2018-12-07 Thread pr-tracker-bot
The pull request you sent on Thu, 6 Dec 2018 21:55:54 +: > git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-4.20-5 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/7f80c7325be49db3fb8b5f343f47691b7999fda7 Thank you! -- Deet-doot-dot, I am a bot.

Re: [GIT PULL] Please pull NFS client changes

2018-11-25 Thread pr-tracker-bot
The pull request you sent on Sun, 25 Nov 2018 03:04:11 +: > git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-4.20-4 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/17c2f540863a6c0faa3f0ede3c785d9427bcaf80 Thank you! -- Deet-doot-dot, I am a bot

Re: [GIT PULL] Please pull NFS client changes for Linux 4.20.

2018-10-26 Thread Linus Torvalds
On Fri, Oct 26, 2018 at 1:21 PM Trond Myklebust wrote: > > We agreed about a year or so ago to take turns maintaining the linux- > next branches. Heh. That was a simpler pattern than I thought. It was just hidden by the fact that there are sometimes more than one pull request during the merge win

Re: [GIT PULL] Please pull NFS client changes for Linux 4.20.

2018-10-26 Thread Trond Myklebust
On Fri, 2018-10-26 at 13:10 -0700, Linus Torvalds wrote: > On Fri, Oct 26, 2018 at 8:45 AM Trond Myklebust < > tron...@hammerspace.com> wrote: > > > > NFS client updates for Linux 4.20 > > Pulled. Thank you! > Btw, just out of curiosity - is there some pattern to when I get the > pull requests

Re: [GIT PULL] Please pull NFS client changes for Linux 4.20.

2018-10-26 Thread Linus Torvalds
On Fri, Oct 26, 2018 at 8:45 AM Trond Myklebust wrote: > > NFS client updates for Linux 4.20 Pulled. Btw, just out of curiosity - is there some pattern to when I get the pull requests from you vs Anna? Or is it just "whoever happens to have the baton"? Not that it matters, but I was wondering if

Re: [GIT PULL] Please pull NFS client changes for 4.18

2018-06-13 Thread Paul E. McKenney
On Wed, Jun 13, 2018 at 11:42:51AM +1000, NeilBrown wrote: > On Tue, Jun 12 2018, Paul E. McKenney wrote: > > > On Tue, Jun 12, 2018 at 06:11:50PM -0700, Linus Torvalds wrote: > >> On Tue, Jun 12, 2018 at 6:02 PM Paul E. McKenney > >> wrote: > >> > > >> > We did review this one, and Neil did make

Re: [GIT PULL] Please pull NFS client changes for 4.18

2018-06-12 Thread NeilBrown
On Tue, Jun 12 2018, Paul E. McKenney wrote: > On Tue, Jun 12, 2018 at 06:11:50PM -0700, Linus Torvalds wrote: >> On Tue, Jun 12, 2018 at 6:02 PM Paul E. McKenney >> wrote: >> > >> > We did review this one, and Neil did make requested changes to the comment >> > header and documentation. >> >> O

Re: [GIT PULL] Please pull NFS client changes for 4.18

2018-06-12 Thread Paul E. McKenney
On Tue, Jun 12, 2018 at 06:11:50PM -0700, Linus Torvalds wrote: > On Tue, Jun 12, 2018 at 6:02 PM Paul E. McKenney > wrote: > > > > We did review this one, and Neil did make requested changes to the comment > > header and documentation. > > Oh, I checked the commit for "acked-by" from you and did

Re: [GIT PULL] Please pull NFS client changes for 4.18

2018-06-12 Thread Linus Torvalds
On Tue, Jun 12, 2018 at 6:02 PM Paul E. McKenney wrote: > > We did review this one, and Neil did make requested changes to the comment > header and documentation. Oh, I checked the commit for "acked-by" from you and didn't see any, so I was assuming this was just Neil and Trond on their own..

Re: [GIT PULL] Please pull NFS client changes for 4.18

2018-06-12 Thread Paul E. McKenney
On Tue, Jun 12, 2018 at 11:08:31AM -0700, Linus Torvalds wrote: > Final note (for now) on this: I've merged the nfs code, but I really > am obviously not happy with these crazy random ad-hoc > cursor-not-cursor list games. We did review this one, and Neil did make requested changes to the comment

Re: [GIT PULL] Please pull NFS client changes for 4.18

2018-06-12 Thread NeilBrown
On Tue, Jun 12 2018, Linus Torvalds wrote: > Final note (for now) on this: I've merged the nfs code, but I really > am obviously not happy with these crazy random ad-hoc > cursor-not-cursor list games. > > Linus Hi Linus, thanks for merging the code despite your reservations. Ye

Re: [GIT PULL] Please pull NFS client changes for 4.18

2018-06-12 Thread Linus Torvalds
Final note (for now) on this: I've merged the nfs code, but I really am obviously not happy with these crazy random ad-hoc cursor-not-cursor list games. Linus

Re: [GIT PULL] Please pull NFS client changes for 4.18

2018-06-12 Thread Linus Torvalds
On Tue, Jun 12, 2018 at 10:42 AM Linus Torvalds wrote: > > So could we please have a cursor entry for RCU walking, and actually > have a agreed-upon way to do this? Maybe even using the low bit in the > "next" field to mark a cursor entry generically - the same way we > already do for the HEAD fie

Re: [GIT PULL] Please pull NFS client changes for 4.18

2018-06-12 Thread Linus Torvalds
On Tue, Jun 12, 2018 at 6:39 AM Trond Myklebust wrote: > > NeilBrown (4): > rculist: add list_for_each_entry_from_rcu() Oh christ, people. Not another one of these. We need to start having a real rule in place where people DO NOT PLAY GAMES WITH RCU LISTS. Adding Paul McKenney to the list

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

2017-08-01 Thread Trond Myklebust
On Tue, 2017-08-01 at 13:50 -0400, da...@codemonkey.org.uk wrote: > On Tue, Aug 01, 2017 at 10:20:31AM -0700, Linus Torvalds wrote: > > > So I think the 'pathname' part may actually be entirely a red > herring, > > and it's the underlying access itself that just picks up a random > > pointer fr

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

2017-08-01 Thread Linus Torvalds
On Tue, Aug 1, 2017 at 10:20 AM, Linus Torvalds wrote: > > So I think the 'pathname' part may actually be entirely a red herring, > and it's the underlying access itself that just picks up a random > pointer from a stack that now contains something different. And KASAN > didn't notice the stale st

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

2017-08-01 Thread da...@codemonkey.org.uk
On Tue, Aug 01, 2017 at 10:20:31AM -0700, Linus Torvalds wrote: > So I think the 'pathname' part may actually be entirely a red herring, > and it's the underlying access itself that just picks up a random > pointer from a stack that now contains something different. And KASAN > didn't notice t

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

2017-08-01 Thread Trond Myklebust
On Tue, 2017-08-01 at 10:20 -0700, Linus Torvalds wrote: > On Tue, Aug 1, 2017 at 8:51 AM, da...@codemonkey.org.uk > wrote: > > On Mon, Jul 31, 2017 at 10:35:45PM -0700, Linus Torvalds wrote: > > > Any chance of getting the output from > > > > > >./scripts/faddr2line vmlinux > > nfs4_exchan

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

2017-08-01 Thread Linus Torvalds
On Tue, Aug 1, 2017 at 8:51 AM, da...@codemonkey.org.uk wrote: > On Mon, Jul 31, 2017 at 10:35:45PM -0700, Linus Torvalds wrote: > > Any chance of getting the output from > > > >./scripts/faddr2line vmlinux nfs4_exchange_id_done+0x3d7/0x8e0 > > > Hm, that points to this.. > > 7463

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

2017-08-01 Thread da...@codemonkey.org.uk
On Mon, Jul 31, 2017 at 10:35:45PM -0700, Linus Torvalds wrote: > On Mon, Jul 31, 2017 at 8:43 AM, da...@codemonkey.org.uk > wrote: > > Another NFSv4 KASAN splat, this time from rc3. > > > > BUG: KASAN: use-after-free in nfs4_exchange_id_done+0x3d7/0x8e0 [nfsv4] > > Ugh. It's really hard t

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

2017-07-31 Thread Linus Torvalds
On Mon, Jul 31, 2017 at 8:43 AM, da...@codemonkey.org.uk wrote: > Another NFSv4 KASAN splat, this time from rc3. > > BUG: KASAN: use-after-free in nfs4_exchange_id_done+0x3d7/0x8e0 [nfsv4] Ugh. It's really hard to tell what access that it - KASAN doesn't actually give enough information. There's

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

2017-07-31 Thread da...@codemonkey.org.uk
Another NFSv4 KASAN splat, this time from rc3. == BUG: KASAN: use-after-free in nfs4_exchange_id_done+0x3d7/0x8e0 [nfsv4] Read of size 8 at addr 8804508af528 by task kworker/2:1/34 CPU: 2 PID: 34 Comm: kworker/2:1 Not tainted 4.

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

2017-07-17 Thread Linus Torvalds
On Sun, Jul 16, 2017 at 8:05 PM, da...@codemonkey.org.uk wrote: > On Sun, Jul 16, 2017 at 10:57:27PM +, Trond Myklebust wrote: > > > > BUG: KASAN: global-out-of-bounds in call_start+0x93/0x100 > > > Read of size 8 at addr 8d582588 by task kworker/0:1/22 > > > > Does the following p

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

2017-07-16 Thread da...@codemonkey.org.uk
On Sun, Jul 16, 2017 at 10:57:27PM +, Trond Myklebust wrote: > > BUG: KASAN: global-out-of-bounds in call_start+0x93/0x100 > > Read of size 8 at addr 8d582588 by task kworker/0:1/22 > > Does the following patch fix it? Yep, seems to do the trick! Dave

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

2017-07-16 Thread Trond Myklebust
Hi Dave, On Sun, 2017-07-16 at 17:15 -0400, Dave Jones wrote: > On Fri, Jul 14, 2017 at 10:25:43AM -0400, Dave Jones wrote: > > On Thu, Jul 13, 2017 at 05:16:24PM -0400, Anna Schumaker wrote: > > > Hi Linus, > > > > > > The following changes since commit > 32c1431eea4881a6b17bd7c639315010a

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

2017-07-16 Thread Dave Jones
On Fri, Jul 14, 2017 at 10:25:43AM -0400, Dave Jones wrote: > On Thu, Jul 13, 2017 at 05:16:24PM -0400, Anna Schumaker wrote: > > Hi Linus, > > > > The following changes since commit > 32c1431eea4881a6b17bd7c639315010aeefa452: > > > > Linux 4.12-rc5 (2017-06-11 16:48:20 -0700) >

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

2017-07-14 Thread Daniel Micay
> I find "hardening" code that adds bugs to be particularly bad and > ugly, the same way that I absolutely *hate* debugging code that turns > out to make debugging impossible (we had that with the "better" stack > tracing code that caused kernel panics to kill the machine entirely > rather than sho

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

2017-07-14 Thread Daniel Micay
> The reason q_size isn't used is because it doesn't yet prevent read > overflow. The commit message mentions that among the current > limitations > along with __builtin_object_size(ptr, 1). Er rather, in strlcat, the q_size is unused after the fast path is because strnlen obtains the constant aga

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

2017-07-14 Thread Daniel Micay
On Fri, 2017-07-14 at 13:50 -0700, Linus Torvalds wrote: > On Fri, Jul 14, 2017 at 1:38 PM, Daniel Micay > wrote: > > > > If strscpy treats the count parameter as a *guarantee* of the dest > > size > > rather than a limit, > > No, it's a *limit*. > > And by a *limit*, I mean that we know that w

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

2017-07-14 Thread Daniel Micay
> My initial patch used strlcpy there, because I wasn't aware of strscpy > before it was suggested: > > http://www.openwall.com/lists/kernel-hardening/2017/05/04/11 > > I was wrong to move it to strscpy. It could be switched back to > strlcpy > again unless the kernel considers the count paramete

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

2017-07-14 Thread Linus Torvalds
On Fri, Jul 14, 2017 at 1:38 PM, Daniel Micay wrote: > > If strscpy treats the count parameter as a *guarantee* of the dest size > rather than a limit, No, it's a *limit*. And by a *limit*, I mean that we know that we can access both source and destination within that limit. > My initial patch

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

2017-07-14 Thread Daniel Micay
On Fri, 2017-07-14 at 12:58 -0700, Linus Torvalds wrote: > On Fri, Jul 14, 2017 at 12:43 PM, Andrey Ryabinin > wrote: > > > > > yet when I look at the generated code for __ip_map_lookup, I see > > > > > >movl$32, %edx #, > > >movq%r13, %rsi # class, > > >

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

2017-07-14 Thread Andrey Rybainin
On 07/14/2017 10:58 PM, Linus Torvalds wrote: > On Fri, Jul 14, 2017 at 12:43 PM, Andrey Ryabinin > wrote: >> >>> yet when I look at the generated code for __ip_map_lookup, I see >>> >>>movl$32, %edx #, >>>movq%r13, %rsi # class, >>>leaq48(%rax), %r

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

2017-07-14 Thread Linus Torvalds
On Fri, Jul 14, 2017 at 12:43 PM, Andrey Ryabinin wrote: > >> yet when I look at the generated code for __ip_map_lookup, I see >> >>movl$32, %edx #, >>movq%r13, %rsi # class, >>leaq48(%rax), %rdi #, tmp126 >>callstrscpy # >> >> what's the

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

2017-07-14 Thread Dave Jones
On Fri, Jul 14, 2017 at 12:05:02PM -0700, Linus Torvalds wrote: > On Fri, Jul 14, 2017 at 7:25 AM, Dave Jones wrote: > > On Thu, Jul 13, 2017 at 05:16:24PM -0400, Anna Schumaker wrote: > > > > > > git://git.linux-nfs.org/projects/anna/linux-nfs.git > > tags/nfs-for-4.13-1 > > > > Since

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

2017-07-14 Thread Andrey Ryabinin
On 07/14/2017 10:05 PM, Linus Torvalds wrote: > On Fri, Jul 14, 2017 at 7:25 AM, Dave Jones wrote: >> On Thu, Jul 13, 2017 at 05:16:24PM -0400, Anna Schumaker wrote: >> > >> > git://git.linux-nfs.org/projects/anna/linux-nfs.git tags/nfs-for-4.13-1 >> >> Since this landed, I'm seeing this dur

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

2017-07-14 Thread Linus Torvalds
On Fri, Jul 14, 2017 at 7:25 AM, Dave Jones wrote: > On Thu, Jul 13, 2017 at 05:16:24PM -0400, Anna Schumaker wrote: > > > > git://git.linux-nfs.org/projects/anna/linux-nfs.git tags/nfs-for-4.13-1 > > Since this landed, I'm seeing this during boot.. > > ===

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

2017-07-14 Thread J. Bruce Fields
On Fri, Jul 14, 2017 at 10:25:43AM -0400, Dave Jones wrote: > On Thu, Jul 13, 2017 at 05:16:24PM -0400, Anna Schumaker wrote: > > Hi Linus, > > > > The following changes since commit > 32c1431eea4881a6b17bd7c639315010aeefa452: > > > > Linux 4.12-rc5 (2017-06-11 16:48:20 -0700) > > > >

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

2017-07-14 Thread Dave Jones
On Thu, Jul 13, 2017 at 05:16:24PM -0400, Anna Schumaker wrote: > Hi Linus, > > The following changes since commit 32c1431eea4881a6b17bd7c639315010aeefa452: > > Linux 4.12-rc5 (2017-06-11 16:48:20 -0700) > > are available in the git repository at: > > git://git.linux-nfs.org/projec

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

2017-07-14 Thread Anna Schumaker
On 07/14/2017 03:09 AM, Christoph Hellwig wrote: > On Thu, Jul 13, 2017 at 02:43:14PM -0700, Linus Torvalds wrote: >> On Thu, Jul 13, 2017 at 2:16 PM, Anna Schumaker >> wrote: >>> >>> git://git.linux-nfs.org/projects/anna/linux-nfs.git tags/nfs-for-4.13-1 >> >> Btw, your key seems to have expi

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

2017-07-14 Thread Christoph Hellwig
On Thu, Jul 13, 2017 at 02:43:14PM -0700, Linus Torvalds wrote: > On Thu, Jul 13, 2017 at 2:16 PM, Anna Schumaker > wrote: > > > > git://git.linux-nfs.org/projects/anna/linux-nfs.git tags/nfs-for-4.13-1 > > Btw, your key seems to have expired, and doing a refresh on it doesn't fix it. > > I'm

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

2017-07-13 Thread Linus Torvalds
On Thu, Jul 13, 2017 at 2:16 PM, Anna Schumaker wrote: > > git://git.linux-nfs.org/projects/anna/linux-nfs.git tags/nfs-for-4.13-1 Btw, your key seems to have expired, and doing a refresh on it doesn't fix it. I'm sure you've refreshed your key, but apparently that refresh hasn't been percolat

Re: [GIT PULL] Please pull NFS client changes for Linux 4.9

2016-10-14 Thread Anna Schumaker
On 10/14/2016 12:24 AM, Linus Torvalds wrote: > On Thu, Oct 13, 2016 at 1:21 PM, Anna Schumaker > wrote: >> >> git://git.linux-nfs.org/projects/anna/linux-nfs.git tags/nfs-for-4.9-1 > > Please keep the summary of changes in the email too. I can see it in > the tag, and it will show up when I do

Re: [GIT PULL] Please pull NFS client changes for Linux 4.9

2016-10-13 Thread Linus Torvalds
On Thu, Oct 13, 2016 at 1:21 PM, Anna Schumaker wrote: > > git://git.linux-nfs.org/projects/anna/linux-nfs.git tags/nfs-for-4.9-1 Please keep the summary of changes in the email too. I can see it in the tag, and it will show up when I do a pull that way, but I'd _really_ like to see it in the e

Re: [GIT PULL] Please pull NFS client changes for Linux 4.7

2016-05-27 Thread Linus Torvalds
On Fri, May 27, 2016 at 5:17 PM, Boris Ostrovsky wrote: > > It does fix it. Ok, I've committed that in my tree, will do my usual build test and push out. > This is not the first time we've hit this and people have always been > changing code to initialize fields in execution path (and I didn't f

Re: [GIT PULL] Please pull NFS client changes for Linux 4.7

2016-05-27 Thread Boris Ostrovsky
- torva...@linux-foundation.org wrote: > On Fri, May 27, 2016 at 10:14 AM, Boris Ostrovsky > wrote: > > > > This breaks on older compilers: > > > > CC fs/nfs/nfs4state.o > > /home/build/linux-linus/fs/nfs/nfs4state.c:69: error: unknown field > > ‘data’ specified in initializer > > Do

Re: [GIT PULL] Please pull NFS client changes for Linux 4.7

2016-05-27 Thread Linus Torvalds
On Fri, May 27, 2016 at 10:14 AM, Boris Ostrovsky wrote: > > This breaks on older compilers: > > CC fs/nfs/nfs4state.o > /home/build/linux-linus/fs/nfs/nfs4state.c:69: error: unknown field > ‘data’ specified in initializer Does the attached patch fix it for you? I don't have easy access t

Re: [GIT PULL] Please pull NFS client changes for Linux 4.7

2016-05-27 Thread Boris Ostrovsky
On 05/26/2016 11:29 AM, Anna Schumaker wrote: > Hi Linus, > > The following changes since commit 44549e8f5eea4e0a41b487b63e616cb089922b99: > > Linux 4.6-rc7 (2016-05-08 14:38:32 -0700) > > are available in the git repository at: > > git://git.linux-nfs.org/projects/anna/linux-nfs.git tags/nfs-f

Re: [GIT PULL] Please pull NFS client changes

2015-09-11 Thread Trond Myklebust
On Fri, Sep 11, 2015 at 12:27 PM, Christoph Hellwig wrote: > On Mon, Sep 07, 2015 at 11:01:36PM -0700, Christoph Hellwig wrote: >> On Tue, Sep 08, 2015 at 11:59:00AM +1000, Stephen Rothwell wrote: >> > This contains about 12 commits new since Sept 1 and the last 6 are only >> > appearing in linux-

Re: [GIT PULL] Please pull NFS client changes

2015-09-11 Thread Christoph Hellwig
On Mon, Sep 07, 2015 at 11:01:36PM -0700, Christoph Hellwig wrote: > On Tue, Sep 08, 2015 at 11:59:00AM +1000, Stephen Rothwell wrote: > > This contains about 12 commits new since Sept 1 and the last 6 are only > > appearing in linux-next today (though I did not do Friday and Monday's > > linux-nex

Re: [GIT PULL] Please pull NFS client changes

2015-09-07 Thread Christoph Hellwig
On Tue, Sep 08, 2015 at 11:59:00AM +1000, Stephen Rothwell wrote: > This contains about 12 commits new since Sept 1 and the last 6 are only > appearing in linux-next today (though I did not do Friday and Monday's > linux-next). Not judging, just noting. And one of tese recent commits causes a reg

Re: [GIT PULL] Please pull NFS client changes

2015-09-07 Thread Stephen Rothwell
Hi Linus, On Mon, 07 Sep 2015 16:59:04 -0400 Trond Myklebust wrote: > > The following changes since commit 74d33293e467df61de1b1d8b2fbe29e550dec33b: > > Linux 4.2-rc5 (2015-08-02 18:34:55 -0700) > > are available in the git repository at: > > git://git.linux-nfs.org/projects/trondmy/linux