Re: [GIT PULL] overlayfs update for 4.14

2017-09-17 Thread Dave Chinner
On Fri, Sep 15, 2017 at 10:06:24AM +0200, Miklos Szeredi wrote: > or some way to have a shared page > cache that's breakable on copy up, which does not look trivial at all. If we get that, it will come through overlay using reflink for copyup and filesystems doing the page cache sharing of multipl

Re: [GIT PULL] overlayfs update for 4.14

2017-09-17 Thread J. R. Okajima
Linus Torvalds: > On Wed, Sep 13, 2017 at 11:46 PM, Miklos Szeredi wrote: > > > > d_real() is currently is *the* overlayfs-op: > > I know. And it's ugly as #%^! hell. > > We don't want to make it uglier. > > And honestly, if you think that "it's only for overlayfs, so I can do > anything I damn w

Re: [GIT PULL] overlayfs update for 4.14

2017-09-15 Thread Linus Torvalds
On Fri, Sep 15, 2017 at 12:32 AM, Miklos Szeredi wrote: > > Fine. Here's a patch reverting the new flags and adding O_UPPER. Thanks, this patch looks fine to me, but now with the other discussion I think I'll leave the d_real() thing alone and see if Al has more comments about your other approac

Re: [GIT PULL] overlayfs update for 4.14

2017-09-15 Thread Miklos Szeredi
On Fri, Sep 15, 2017 at 9:32 AM, Miklos Szeredi wrote: > On Thu, Sep 14, 2017 at 01:24:22PM -0700, Linus Torvalds wrote: > >> I just don't see any reason why those two "flags" arguments are separate. > > Fine. Here's a patch reverting the new flags and adding O_UPPER. And, btw. I also hate all t

Re: [GIT PULL] overlayfs update for 4.14

2017-09-15 Thread Miklos Szeredi
On Thu, Sep 14, 2017 at 01:24:22PM -0700, Linus Torvalds wrote: > I just don't see any reason why those two "flags" arguments are separate. Fine. Here's a patch reverting the new flags and adding O_UPPER. Thanks, Miklos --- From: Miklos Szeredi Subject: vfs: d_real: merge flags and open_flags

Re: [GIT PULL] overlayfs update for 4.14

2017-09-14 Thread Linus Torvalds
On Thu, Sep 14, 2017 at 1:12 PM, Miklos Szeredi wrote: > > I was saying that it's a bad idea to mix external and internal flags. > That was the reason the two were separated on that API. I'm open to > arguments about that. The thing is, I don't think "upper layer" is any more internal than "direc

Re: [GIT PULL] overlayfs update for 4.14

2017-09-14 Thread Miklos Szeredi
On Thu, Sep 14, 2017 at 10:00 PM, Linus Torvalds wrote: > If you can't bother to try to make it act as a proper VFS thing, then > I don't want to see patches from you to the VFS code. I was saying that it's a bad idea to mix external and internal flags. That was the reason the two were separated

Re: [GIT PULL] overlayfs update for 4.14

2017-09-14 Thread Linus Torvalds
On Wed, Sep 13, 2017 at 11:46 PM, Miklos Szeredi wrote: > > d_real() is currently is *the* overlayfs-op: I know. And it's ugly as #%^! hell. We don't want to make it uglier. And honestly, if you think that "it's only for overlayfs, so I can do anything I damn well want to this p[iece of shit"

Re: [GIT PULL] overlayfs update for 4.14

2017-09-13 Thread Miklos Szeredi
On Wed, Sep 13, 2017 at 6:25 PM, Linus Torvalds wrote: > On Wed, Sep 13, 2017 at 7:05 AM, Miklos Szeredi wrote: >> >> There are also some bug fixes, one in particular (random ioctl's shouldn't be >> able to modify lower layers) that touches some vfs code, but of course no-op >> for >> non-overla

Re: [GIT PULL] overlayfs update for 4.14

2017-09-13 Thread Linus Torvalds
On Wed, Sep 13, 2017 at 7:05 AM, Miklos Szeredi wrote: > > There are also some bug fixes, one in particular (random ioctl's shouldn't be > able to modify lower layers) that touches some vfs code, but of course no-op > for > non-overlay fs. Argh. I _despise_ those changes to 'd_real()'. I reall