Re: [GIT PULL 5/9] intel_th: msu: Introduce buffer driver interface

2019-07-05 Thread Alexander Shishkin
Greg Kroah-Hartman writes: > Anyway, this patch is odd, please re-review it. Fixed & updated version [1] should be in your inbox about now. [1] https://marc.info/?l=linux-kernel&m=156233609417236 Thanks, -- Alex

Re: [GIT PULL 5/9] intel_th: msu: Introduce buffer driver interface

2019-07-03 Thread Greg Kroah-Hartman
On Wed, Jul 03, 2019 at 07:33:58PM +0300, Alexander Shishkin wrote: > Greg Kroah-Hartman writes: > > >> + /* > >> + * ->assign() called when buffer 'mode' is set to this driver > >> + * (aka mode_store()) > >> + * @device: struct device * of the msc > >> + * @mode: allows the

Re: [GIT PULL 5/9] intel_th: msu: Introduce buffer driver interface

2019-07-03 Thread Alexander Shishkin
Greg Kroah-Hartman writes: >> +/* >> + * ->assign() called when buffer 'mode' is set to this driver >> + * (aka mode_store()) >> + * @device: struct device * of the msc >> + * @mode: allows the driver to set HW mode (see the enum above) >> + * Returns: a po

Re: [GIT PULL 5/9] intel_th: msu: Introduce buffer driver interface

2019-07-03 Thread Greg Kroah-Hartman
On Thu, Jun 27, 2019 at 03:51:48PM +0300, Alexander Shishkin wrote: > Introduces a concept of buffer drivers, which is a mechanism for creating > trace sinks that would receive trace data from MSC buffers and transfer it > elsewhere. > > A buffer driver can implement its own window allocation/deal