Re: [Linux-fbdev-devel] fb: modedb uses wrong default_mode

2006-11-18 Thread Tero Roponen
On Fri, 17 Nov 2006, Andrew Morton wrote: > > Here's the current version of this monster patch: > > From: Jordan Crouse <[EMAIL PROTECTED]> > > If no default mode is specified, it should be grabbed from the supplied > database, not the default one. > > [EMAIL PROTECTED]: fix it] > [EMAIL PROTEC

Re: [Linux-fbdev-devel] fb: modedb uses wrong default_mode

2006-11-17 Thread Andrew Morton
On Fri, 17 Nov 2006 20:08:47 + (GMT) James Simmons <[EMAIL PROTECTED]> wrote: > Who knows how many drivers get this wrong. BTW Jordan is right. > DEFAULT_MODEDB_INDEX is unless. Also we don't need dbsize anymore. > Jordan did point out a error in fb_find_mode. It should be > > if (!db

Re: [Linux-fbdev-devel] fb: modedb uses wrong default_mode

2006-11-17 Thread James Simmons
> > > It seems that default_mode is always overwritten in > > > fb_find_mode() if caller gives its own modedb; this > > > patch should fix it. > > > Sigh. > > > > 2.6.19-rc5 has: > > > > if (!default_mode) > > default_mode = &modedb[DEFAULT_MODEDB_INDEX]; > > > > and Jordan changed it