Re: [NOT VERY SAFE] [TCP]: Set initial_ssthresh default to zero in Cubic and BIC.

2007-10-15 Thread Stephen Hemminger
On Mon, 15 Oct 2007 21:59:49 +0900 Komuro <[EMAIL PROTECTED]> wrote: > Dear shemminger > > >In which case it is zero because that is the default value. > > The default value of snd_ssthresh is 0x7fff, isn't it? > > [linux/net/ipv4/tcp_ipv4.c] > static int tcp_v4_init_sock(struct sock *sk) >

Re: [NOT VERY SAFE] [TCP]: Set initial_ssthresh default to zero in Cubic and BIC.

2007-10-15 Thread Komuro
Dear shemminger >In which case it is zero because that is the default value. The default value of snd_ssthresh is 0x7fff, isn't it? [linux/net/ipv4/tcp_ipv4.c] static int tcp_v4_init_sock(struct sock *sk) ... tp->snd_ssthresh = 0x7fff; /* Infinity */ ... Best Regards Komuro >

Re: [NOT VERY SAFE] [TCP]: Set initial_ssthresh default to zero in Cubic and BIC.

2007-10-14 Thread Stephen Hemminger
On Sun, 14 Oct 2007 10:02:45 +0900 Komuro <[EMAIL PROTECTED]> wrote: > Dear David > > Actually, tcp_sk(sk)->snd_ssthresh is not initialized, > if initial_ssthresh is 0. > > The patch should be > > static void bictcp_init(struct sock *sk) > { > bictcp_reset(inet_csk_ca(sk)); > - if (

Re: [NOT VERY SAFE] [TCP]: Set initial_ssthresh default to zero in Cubic and BIC.

2007-10-13 Thread David Miller
From: Komuro <[EMAIL PROTECTED]> Date: Sun, 14 Oct 2007 13:53:56 +0900 > Sorry, my mailer's mail-address setting is wrong. Thank you for fixing this :-) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [NOT VERY SAFE] [TCP]: Set initial_ssthresh default to zero in Cubic and BIC.

2007-10-13 Thread Komuro
Dear David Sorry, my mailer's mail-address setting is wrong. Best Regards Komuro - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at htt

Re: [NOT VERY SAFE] [TCP]: Set initial_ssthresh default to zero in Cubic and BIC.

2007-10-13 Thread David Miller
From: Komuro <[EMAIL PROTECTED]> Date: Sun, 14 Oct 2007 13:28:51 +0900 > > Dear David > > >Komuro, every single email I sent to you bounces with "user unknown", > >I bet it is some spam filter or similar that doesn't like the > >fact that I lack reverse DNS. > > >From mailing-list-archive, > I

Re: [NOT VERY SAFE] [TCP]: Set initial_ssthresh default to zero in Cubic and BIC.

2007-10-13 Thread Jeff Garzik
David Miller wrote: From: Komuro <[EMAIL PROTECTED]> Date: Sun, 14 Oct 2007 10:02:45 +0900 Dear David Actually, tcp_sk(sk)->snd_ssthresh is not initialized, if initial_ssthresh is 0. Komuro, every single email I sent to you bounces with "user unknown", I bet it is some spam filter or similar

Re: [NOT VERY SAFE] [TCP]: Set initial_ssthresh default to zero in Cubic and BIC.

2007-10-13 Thread Komuro
Dear David >Komuro, every single email I sent to you bounces with "user unknown", >I bet it is some spam filter or similar that doesn't like the >fact that I lack reverse DNS. >From mailing-list-archive, I can read your email. Best Regards Komuro > Dear David > > Actually, tcp_sk(sk)->snd_sst

Re: [NOT VERY SAFE] [TCP]: Set initial_ssthresh default to zero in Cubic and BIC.

2007-10-13 Thread David Miller
From: Komuro <[EMAIL PROTECTED]> Date: Sun, 14 Oct 2007 10:02:45 +0900 > Dear David > > Actually, tcp_sk(sk)->snd_ssthresh is not initialized, > if initial_ssthresh is 0. Komuro, every single email I sent to you bounces with "user unknown", I bet it is some spam filter or similar that doesn't li

Re: [NOT VERY SAFE] [TCP]: Set initial_ssthresh default to zero in Cubic and BIC.

2007-10-13 Thread Komuro
Dear David Actually, tcp_sk(sk)->snd_ssthresh is not initialized, if initial_ssthresh is 0. The patch should be static void bictcp_init(struct sock *sk) { bictcp_reset(inet_csk_ca(sk)); - if (initial_ssthresh) - tcp_sk(sk)->snd_ssthresh = initial_ssthresh; + +

Re: [NOT VERY SAFE] [TCP]: Set initial_ssthresh default to zero in Cubic and BIC.

2007-10-13 Thread David Miller
From: David Miller <[EMAIL PROTECTED]> Date: Sat, 13 Oct 2007 15:52:11 -0700 (PDT) > From: Komuro <[EMAIL PROTECTED]> > Date: Sun, 14 Oct 2007 07:36:58 +0900 BTW, even my reply didn't reach him, nifty.com reports "user unknown" for him. I really, truly, suspect therefore that he has other kinds

Re: [NOT VERY SAFE] [TCP]: Set initial_ssthresh default to zero in Cubic and BIC.

2007-10-13 Thread David Miller
From: Komuro <[EMAIL PROTECTED]> Date: Sun, 14 Oct 2007 07:36:58 +0900 > > Dear David > > The patch "[TCP]: Set initial_ssthresh default to zero in Cubic and BIC." > is not very safe. > > With this patch, ftp-transfer stops in my system. > (vsftpd-2.0.5-8) > > Please revert this patch. No, I