Re: [PART1 RFC v3 10/12] svm: Do not expose x2APIC when enable AVIC

2016-04-05 Thread Suravee Suthikulpanit
Hi Paolo, On 3/31/16 18:23, Paolo Bonzini wrote: On 31/03/2016 06:15, Suravee Suthikulpanit wrote: +vcpu->arch.cpuid_entries[i].ecx &= ~(1 << 21); and X86_FEATURE_X2APIC (or something with X2APIC in name) for the bit. The code will become so obvious that the comment can be

Re: [PART1 RFC v3 10/12] svm: Do not expose x2APIC when enable AVIC

2016-03-31 Thread Paolo Bonzini
On 31/03/2016 06:15, Suravee Suthikulpanit wrote: >>> +vcpu->arch.cpuid_entries[i].ecx &= ~(1 << 21); >> >> and X86_FEATURE_X2APIC (or something with X2APIC in name) for the >> bit. >> >> The code will become so obvious that the comment can be removed. >> :) > > Good point. I c

Re: [PART1 RFC v3 10/12] svm: Do not expose x2APIC when enable AVIC

2016-03-30 Thread Suravee Suthikulpanit
Hi Radim, On 03/19/2016 03:59 AM, Radim Krčmář wrote: 2016-03-18 01:09-0500, Suravee Suthikulpanit: From: Suravee Suthikulpanit Since AVIC only virtualizes xAPIC hardware for the guest, we need to: * Intercept APIC BAR msr accesses to disable x2APIC * Intercept CPUID access to not a

Re: [PART1 RFC v3 10/12] svm: Do not expose x2APIC when enable AVIC

2016-03-19 Thread Radim Krčmář
2016-03-18 01:09-0500, Suravee Suthikulpanit: > From: Suravee Suthikulpanit > > Since AVIC only virtualizes xAPIC hardware for the guest, we need to: > * Intercept APIC BAR msr accesses to disable x2APIC > * Intercept CPUID access to not advertise x2APIC support > * Hide x2APIC suppor