Re: [PATCH, -v2] compiler/gcc4: Add quirk for 'asm goto' miscompilation bug

2013-10-10 Thread Ingo Molnar
* Peter Zijlstra wrote: > > So for >= 4.8.3 just assume no workaround is needed, otherwise scan > > assembly. > > Right, tedious and error prone it is.. :-) > > Would it make sense to create something whereby GCC can tell us about > these things? Maybe something like: > > __builtin_bug_fi

Re: [PATCH, -v2] compiler/gcc4: Add quirk for 'asm goto' miscompilation bug

2013-10-10 Thread Peter Zijlstra
On Thu, Oct 10, 2013 at 02:32:36PM +0200, Jakub Jelinek wrote: > On Thu, Oct 10, 2013 at 01:56:17PM +0200, Peter Zijlstra wrote: > > We didn't do version checks for CC_HAVE_ASM_GOTO because of vendor > > backports; can't we detect this in the same way? > > The problem is that it will be harder to

Re: [PATCH, -v2] compiler/gcc4: Add quirk for 'asm goto' miscompilation bug

2013-10-10 Thread Jakub Jelinek
On Thu, Oct 10, 2013 at 01:56:17PM +0200, Peter Zijlstra wrote: > On Thu, Oct 10, 2013 at 10:55:06AM +0200, Ingo Molnar wrote: > > +/* > > + * GCC 'asm goto' miscompiles certain code sequences: > > + * > > + * http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58670 > > + * > > + * Work it around via qu

Re: [PATCH, -v2] compiler/gcc4: Add quirk for 'asm goto' miscompilation bug

2013-10-10 Thread Peter Zijlstra
On Thu, Oct 10, 2013 at 10:55:06AM +0200, Ingo Molnar wrote: > +/* > + * GCC 'asm goto' miscompiles certain code sequences: > + * > + * http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58670 > + * > + * Work it around via quirk suggested by Jakub Jelinek. > + * Fixed in GCC 4.8.2 and later versions. >