Re: [PATCH+DISCUSSION] irqchip: armada-370-xp: Remove redundant ops assignment

2019-06-13 Thread Benjamin Herrenschmidt
On Wed, 2019-06-12 at 15:16 +1000, Benjamin Herrenschmidt wrote: > pci_msi_create_irq_domain -> pci_msi_domain_update_chip_ops will > set those two already since the driver sets MSI_FLAG_USE_DEF_CHIP_OPS > > Signed-off-by: Benjamin Herrenschmidt > --- > > [UNTESTED] > > Just something I noticed

Re: [PATCH+DISCUSSION] irqchip: armada-370-xp: Remove redundant ops assignment

2019-06-13 Thread Marc Zyngier
Hi Ben, On Wed, 12 Jun 2019 06:16:05 +0100, Benjamin Herrenschmidt wrote: > > pci_msi_create_irq_domain -> pci_msi_domain_update_chip_ops will > set those two already since the driver sets MSI_FLAG_USE_DEF_CHIP_OPS > > Signed-off-by: Benjamin Herrenschmidt > --- > > [UNTESTED] > > Just somet

Re: [PATCH+DISCUSSION] irqchip: armada-370-xp: Remove redundant ops assignment

2019-06-13 Thread Benjamin Herrenschmidt
On Thu, 2019-06-13 at 10:22 +0100, Marc Zyngier wrote: > > It looks to me that masking at the PCI level is rather superfluous as > long as the MSI controller HW has the capability to mask the interrupt > on a per MSI basis. After all, most non MSI-X endpoint lack support > for masking of individua