Re: [PATCH/RFC v3 5/5] media: Add registration helpers for V4L2 flash sub-devices

Hi Jacek, On Fri, May 09, 2014 at 09:18:55AM +0200, Jacek Anaszewski wrote: > Hi Sakari, > > On 05/07/2014 09:58 AM, Sakari Ailus wrote: > >Hi Jacek, > > > >On Wed, May 07, 2014 at 09:20:17AM +0200, Jacek Anaszewski wrote: > >>On 05/06/2014 11:10 AM, Sakari Ailus wrote: > >>>Hi Jacek, > >>> > >>>

Re: [PATCH/RFC v3 5/5] media: Add registration helpers for V4L2 flash sub-devices

Hi Sakari, On 05/07/2014 09:58 AM, Sakari Ailus wrote: Hi Jacek, On Wed, May 07, 2014 at 09:20:17AM +0200, Jacek Anaszewski wrote: On 05/06/2014 11:10 AM, Sakari Ailus wrote: Hi Jacek, On Tue, May 06, 2014 at 08:44:41AM +0200, Jacek Anaszewski wrote: Hi Sakari, On 05/02/2014 01:06 PM, Saka

Re: [PATCH/RFC v3 5/5] media: Add registration helpers for V4L2 flash sub-devices

Hi Jacek, On Wed, May 07, 2014 at 09:20:17AM +0200, Jacek Anaszewski wrote: > On 05/06/2014 11:10 AM, Sakari Ailus wrote: > >Hi Jacek, > > > >On Tue, May 06, 2014 at 08:44:41AM +0200, Jacek Anaszewski wrote: > >>Hi Sakari, > >> > >>On 05/02/2014 01:06 PM, Sakari Ailus wrote: > >> > >>[...] > >

Re: [PATCH/RFC v3 5/5] media: Add registration helpers for V4L2 flash sub-devices

On 05/06/2014 11:10 AM, Sakari Ailus wrote: Hi Jacek, On Tue, May 06, 2014 at 08:44:41AM +0200, Jacek Anaszewski wrote: Hi Sakari, On 05/02/2014 01:06 PM, Sakari Ailus wrote: [...] +static inline enum led_brightness v4l2_flash_intensity_to_led_brightness( +

Re: [PATCH/RFC v3 5/5] media: Add registration helpers for V4L2 flash sub-devices

Hi Jacek, On Tue, May 06, 2014 at 08:44:41AM +0200, Jacek Anaszewski wrote: > Hi Sakari, > > On 05/02/2014 01:06 PM, Sakari Ailus wrote: > > [...] > >>+static inline enum led_brightness > >>v4l2_flash_intensity_to_led_brightness( > >>+ struc

Re: [PATCH/RFC v3 5/5] media: Add registration helpers for V4L2 flash sub-devices

Hi Sakari, On 05/02/2014 01:06 PM, Sakari Ailus wrote: [...] +static inline enum led_brightness v4l2_flash_intensity_to_led_brightness( + struct led_ctrl *config, + u32 intensity) Fits on a single line. +{ +

Re: [PATCH/RFC v3 5/5] media: Add registration helpers for V4L2 flash sub-devices

Hi Jacek, On Mon, Apr 28, 2014 at 01:25:09PM +0200, Jacek Anaszewski wrote: > Hi Sakari, > > On 04/23/2014 05:24 PM, Sakari Ailus wrote: > >Hi Jacek, > > > >On Thu, Apr 17, 2014 at 10:26:44AM +0200, Jacek Anaszewski wrote: > >>Hi Sakari, > >> > >>Thanks for the review. > >> > >>On 04/16/2014 08:2

Re: [PATCH/RFC v3 5/5] media: Add registration helpers for V4L2 flash sub-devices

Hi Sakari, On 04/23/2014 05:24 PM, Sakari Ailus wrote: Hi Jacek, On Thu, Apr 17, 2014 at 10:26:44AM +0200, Jacek Anaszewski wrote: Hi Sakari, Thanks for the review. On 04/16/2014 08:21 PM, Sakari Ailus wrote: Hi Jacek, Thanks for the update! [...] +static inline enum led_brightness v4l2

Re: [PATCH/RFC v3 5/5] media: Add registration helpers for V4L2 flash sub-devices

Hi Jacek, On Thu, Apr 17, 2014 at 10:26:44AM +0200, Jacek Anaszewski wrote: > Hi Sakari, > > Thanks for the review. > > On 04/16/2014 08:21 PM, Sakari Ailus wrote: > >Hi Jacek, > > > >Thanks for the update! > > > [...] > >>+static inline enum led_brightness v4l2_flash_intensity_to_led_brightness

Re: [PATCH/RFC v3 5/5] media: Add registration helpers for V4L2 flash sub-devices

Hi Sakari, Thanks for the review. On 04/16/2014 08:21 PM, Sakari Ailus wrote: Hi Jacek, Thanks for the update! [...] +static inline enum led_brightness v4l2_flash_intensity_to_led_brightness( + struct led_ctrl *config, +

Re: [PATCH/RFC v3 5/5] media: Add registration helpers for V4L2 flash sub-devices

Hi Jacek, Thanks for the update! On Fri, Apr 11, 2014 at 04:56:56PM +0200, Jacek Anaszewski wrote: > This patch adds helper functions for registering/unregistering > LED class flash devices as V4L2 subdevs. The functions should > be called from the LED subsystem device driver. In case the > suppo