Re: [PATCH][next] PCI: brcmstb: fix a missing if statement on a return error check

On 21/09/2020 21:53, Jim Quinlan wrote: > Hello, > I am fine with Colin's suggested change or Florians as well: > > ret = brcm_phy_start(pcie); > +if (ret) { > +clk_disable_unprepare(pcie->clk); > return ret; > +} > > Currently, our STB up

Re: [PATCH][next] PCI: brcmstb: fix a missing if statement on a return error check

Hello, I am fine with Colin's suggested change or Florians as well: ret = brcm_phy_start(pcie); +if (ret) { +clk_disable_unprepare(pcie->clk); return ret; +} Currently, our STB upstream suspend/resume is not functional yet and this is how

Re: [PATCH][next] PCI: brcmstb: fix a missing if statement on a return error check

On 9/21/20 7:40 AM, Colin King wrote: > From: Colin Ian King > > The error return ret is not being check with an if statement and > currently the code always returns leaving the following code as > dead code. Fix this by adding in the missing if statement. > > Addresses-Coverity: ("Structurally