Re: [PATCH] [v1.1 2/3] fix reset gpio config error

2016-07-07 Thread Dmitry Torokhov
On Thu, Jul 07, 2016 at 09:39:00AM -0700, jeffrey.lin wrote: > ts->reset_gpio=0 will let raydium IC enter reset mode, and ts->reset_gpio=1 > will be normal touch mode. > > Signed-off-by: jeffrey.lin As I mentioned in the original review, this is wrong. gpiod APIs take into account the declared

Re: [PATCH] [v1.1 2/3] fix reset gpio config error

2016-07-07 Thread Guenter Roeck
On Thu, Jul 7, 2016 at 9:39 AM, jeffrey.lin wrote: > ts->reset_gpio=0 will let raydium IC enter reset mode, and ts->reset_gpio=1 > will be normal touch mode. Normally "1" means active. Why is it different here ? I think this warrants a better explanation. Also, if this was really wrong, wouldn'