Re: [PATCH] [v2] ieee802154: ca8210: Fix a potential UAF in ca8210_probe

2023-09-26 Thread Alexander Aring
Hi, On Tue, Sep 26, 2023 at 4:29 AM Stefan Schmidt wrote: > > Hello. > > On 26.09.23 10:02, Miquel Raynal wrote: > > Hi Dinghao, > > > > dinghao@zju.edu.cn wrote on Tue, 26 Sep 2023 11:22:44 +0800: > > > >> If of_clk_add_provider() fails in ca8210_register_ext_clock(), > >> it calls clk_unreg

Re: [PATCH] [v2] ieee802154: ca8210: Fix a potential UAF in ca8210_probe

2023-09-26 Thread dinghao . liu
> Missing Cc stable, this needs to be backported. I will cc stable (sta...@vger.kernel.org) for the next version, thanks! > > diff --git a/drivers/net/ieee802154/ca8210.c > > b/drivers/net/ieee802154/ca8210.c > > index aebb19f1b3a4..b35c6f59bd1a 100644 > > --- a/drivers/net/ieee802154/ca8210.c >

Re: [PATCH] [v2] ieee802154: ca8210: Fix a potential UAF in ca8210_probe

2023-09-26 Thread Stefan Schmidt
Hello. On 26.09.23 10:02, Miquel Raynal wrote: Hi Dinghao, dinghao@zju.edu.cn wrote on Tue, 26 Sep 2023 11:22:44 +0800: If of_clk_add_provider() fails in ca8210_register_ext_clock(), it calls clk_unregister() to release priv->clk and returns an error. However, the caller ca8210_probe() th

Re: [PATCH] [v2] ieee802154: ca8210: Fix a potential UAF in ca8210_probe

2023-09-26 Thread Miquel Raynal
Hi Dinghao, dinghao@zju.edu.cn wrote on Tue, 26 Sep 2023 11:22:44 +0800: > If of_clk_add_provider() fails in ca8210_register_ext_clock(), > it calls clk_unregister() to release priv->clk and returns an > error. However, the caller ca8210_probe() then calls ca8210_remove(), > where priv->clk i