Re: [PATCH] [v5] clocksource/drivers/npcm: fix GENMASK and timer operation

2019-08-21 Thread Avi Fishman
Thanks Daniel, It seems more clear now :) Good to know about the need for Fixes tag. On Wed, Aug 21, 2019 at 1:11 PM Daniel Lezcano wrote: > > On 29/07/2019 19:03, Avi Fishman wrote: > > NPCM7XX_Tx_OPER GENMASK bits where wrong, > > Since NPCM7XX_REG_TICR0 register reset value of those bits was

Re: [PATCH] [v5] clocksource/drivers/npcm: fix GENMASK and timer operation

2019-08-21 Thread Daniel Lezcano
On 29/07/2019 19:03, Avi Fishman wrote: > NPCM7XX_Tx_OPER GENMASK bits where wrong, > Since NPCM7XX_REG_TICR0 register reset value of those bits was 0, > it did not cause an issue. > in npcm7xx_timer_oneshot() the original NPCM7XX_REG_TCSR0 register was > read again after masking it with ~NPCM7XX_T