Re: Re: [PATCH] ALSA: usb-audio: Fix memleak in scarlett2_add_new_ctl

Takashi Iwai ti...@suse.de写道： > On Fri, 07 Aug 2020 09:12:27 +0200, > Dinghao Liu wrote: > > > > When snd_usb_mixer_add_control() fails, elem needs to be > > freed just like when snd_ctl_new1() fails. However, current > > code is returning directly and ends up leaking memory. > > No, this

Re: [PATCH] ALSA: usb-audio: Fix memleak in scarlett2_add_new_ctl

On Fri, 07 Aug 2020 09:12:27 +0200, Dinghao Liu wrote: > > When snd_usb_mixer_add_control() fails, elem needs to be > freed just like when snd_ctl_new1() fails. However, current > code is returning directly and ends up leaking memory. No, this would lead to double-free. snd_ctl_add() shows a