Re: [PATCH] APEI / ERST: Fix missing error handling in erst_reader()

2017-12-17 Thread Rafael J. Wysocki
On Thursday, December 14, 2017 1:31:16 PM CET Takashi Iwai wrote: > The commit f6f828513290 ("pstore: pass allocated memory region back to > caller") changed the check of the return value from erst_read() in > erst_reader() in the following way: > > if (len == -ENOENT) > go

Re: [PATCH] APEI / ERST: Fix missing error handling in erst_reader()

2017-12-15 Thread Borislav Petkov
On Fri, Dec 15, 2017 at 08:22:32AM +0100, Takashi Iwai wrote: > On Fri, 15 Dec 2017 02:01:20 +0100, > Rafael J. Wysocki wrote: > > > > On Thu, Dec 14, 2017 at 1:31 PM, Takashi Iwai wrote: > > > The commit f6f828513290 ("pstore: pass allocated memory region back to > > > caller") changed the check

Re: [PATCH] APEI / ERST: Fix missing error handling in erst_reader()

2017-12-14 Thread Takashi Iwai
On Fri, 15 Dec 2017 02:01:20 +0100, Rafael J. Wysocki wrote: > > On Thu, Dec 14, 2017 at 1:31 PM, Takashi Iwai wrote: > > The commit f6f828513290 ("pstore: pass allocated memory region back to > > caller") changed the check of the return value from erst_read() in > > erst_reader() in the followin

Re: [PATCH] APEI / ERST: Fix missing error handling in erst_reader()

2017-12-14 Thread Kees Cook
On Thu, Dec 14, 2017 at 5:01 PM, Rafael J. Wysocki wrote: > On Thu, Dec 14, 2017 at 1:31 PM, Takashi Iwai wrote: >> The commit f6f828513290 ("pstore: pass allocated memory region back to >> caller") changed the check of the return value from erst_read() in >> erst_reader() in the following way: >

Re: [PATCH] APEI / ERST: Fix missing error handling in erst_reader()

2017-12-14 Thread Rafael J. Wysocki
On Thu, Dec 14, 2017 at 1:31 PM, Takashi Iwai wrote: > The commit f6f828513290 ("pstore: pass allocated memory region back to > caller") changed the check of the return value from erst_read() in > erst_reader() in the following way: > > if (len == -ENOENT) > goto skip; > -