Re: [PATCH] ARM: dts: document pinctrl-single,pins when #pinctrl-cells = 2

2020-10-01 Thread Tony Lindgren
* Trent Piepho [200930 18:50]: > On Wed, Sep 30, 2020 at 2:47 AM Tony Lindgren wrote: > > > > * Trent Piepho [200930 09:34]: > > > > > > > Where do these flags go? In pinctrl-single,pins? Like: > > > > > > pinctrl-single,pins = ; > > > > > > But PIN_INPUT_PULLUP is a generic flag? Which is t

Re: [PATCH] ARM: dts: document pinctrl-single,pins when #pinctrl-cells = 2

2020-09-30 Thread Trent Piepho
On Wed, Sep 30, 2020 at 2:47 AM Tony Lindgren wrote: > > * Trent Piepho [200930 09:34]: > > > > Where do these flags go? In pinctrl-single,pins? Like: > > > > pinctrl-single,pins = ; > > > > But PIN_INPUT_PULLUP is a generic flag? Which is translated into the > > proper value by?? > > Yes tha

Re: [PATCH] ARM: dts: document pinctrl-single,pins when #pinctrl-cells = 2

2020-09-30 Thread Tony Lindgren
* Trent Piepho [200930 09:34]: > On Wed, Sep 30, 2020 at 2:15 AM Tony Lindgren wrote: > > > > * Trent Piepho [200930 08:35]: > > > The closest thing would be the generic pin config type bindings, which > > > go in the pinctrl driver's nodes, and look like this: > > > &am335x_pinmux { > > > p

Re: [PATCH] ARM: dts: document pinctrl-single,pins when #pinctrl-cells = 2

2020-09-30 Thread Trent Piepho
On Wed, Sep 30, 2020 at 2:15 AM Tony Lindgren wrote: > > * Trent Piepho [200930 08:35]: > > The closest thing would be the generic pin config type bindings, which > > go in the pinctrl driver's nodes, and look like this: > > &am335x_pinmux { > > pinctrl_yoyo_reset: yoyogrp { > > pins

Re: [PATCH] ARM: dts: document pinctrl-single,pins when #pinctrl-cells = 2

2020-09-30 Thread Tony Lindgren
* Trent Piepho [200930 08:35]: > The closest thing would be the generic pin config type bindings, which > go in the pinctrl driver's nodes, and look like this: > &am335x_pinmux { > pinctrl_yoyo_reset: yoyogrp { > pins = "foo"; > function = "gpio"; > bias-pull-up; >

Re: [PATCH] ARM: dts: document pinctrl-single,pins when #pinctrl-cells = 2

2020-09-30 Thread Trent Piepho
On Tue, Sep 29, 2020 at 10:15 PM Tony Lindgren wrote: > * Trent Piepho [200929 20:16]: > > On Thu, Sep 24, 2020 at 12:04 AM Tony Lindgren wrote: > > > Certainly different compatible strings can be used as needed. > > > But pinctrl-single is not going to be am335x specific though :) > > > We have

Re: [PATCH] ARM: dts: document pinctrl-single,pins when #pinctrl-cells = 2

2020-09-29 Thread Tony Lindgren
* Trent Piepho [200929 20:16]: > On Thu, Sep 24, 2020 at 12:04 AM Tony Lindgren wrote: > > Certainly different compatible strings can be used as needed. > > But pinctrl-single is not going to be am335x specific though :) > > We have quite a few SoCs using it: > > So what doesn't make sense to me

Re: [PATCH] ARM: dts: document pinctrl-single,pins when #pinctrl-cells = 2

2020-09-29 Thread Trent Piepho
On Thu, Sep 24, 2020 at 12:04 AM Tony Lindgren wrote: > > * Trent Piepho [200924 06:31]: > > > > > > > > The pinctrl-single driver? How will that work with boards that are > > > > not am335x and don't use conf and mux fields in the same manner as > > > > am335x? > > > > > > For those cases we st

Re: [PATCH] ARM: dts: document pinctrl-single,pins when #pinctrl-cells = 2

2020-09-24 Thread Tony Lindgren
* Trent Piepho [200924 06:31]: > On Wed, Sep 23, 2020 at 11:06 PM Tony Lindgren wrote: > > > > * Trent Piepho [200924 05:49]: > > > On Wed, Sep 23, 2020 at 10:43 PM Tony Lindgren wrote: > > > > > > > > * Trent Piepho [200924 01:34]: > > > > > On Tue, Sep 22, 2020 at 11:57 PM Tony Lindgren >

Re: [PATCH] ARM: dts: document pinctrl-single,pins when #pinctrl-cells = 2

2020-09-23 Thread Trent Piepho
On Wed, Sep 23, 2020 at 11:06 PM Tony Lindgren wrote: > > * Trent Piepho [200924 05:49]: > > On Wed, Sep 23, 2020 at 10:43 PM Tony Lindgren wrote: > > > > > > * Trent Piepho [200924 01:34]: > > > > On Tue, Sep 22, 2020 at 11:57 PM Tony Lindgren wrote: > > > > > > > > > > Also FYI, folks have a

Re: [PATCH] ARM: dts: document pinctrl-single,pins when #pinctrl-cells = 2

2020-09-23 Thread Tony Lindgren
* Trent Piepho [200924 05:49]: > On Wed, Sep 23, 2020 at 10:43 PM Tony Lindgren wrote: > > > > * Trent Piepho [200924 01:34]: > > > On Tue, Sep 22, 2020 at 11:57 PM Tony Lindgren wrote: > > > > > > > > Also FYI, folks have also complained for a long time that the > > > > pinctrl-single > > > >

Re: [PATCH] ARM: dts: document pinctrl-single,pins when #pinctrl-cells = 2

2020-09-23 Thread Trent Piepho
On Wed, Sep 23, 2020 at 10:43 PM Tony Lindgren wrote: > > * Trent Piepho [200924 01:34]: > > On Tue, Sep 22, 2020 at 11:57 PM Tony Lindgren wrote: > > > > > > Also FYI, folks have also complained for a long time that the > > > pinctrl-single > > > binding mixes mux and conf values while they sh

Re: [PATCH] ARM: dts: document pinctrl-single,pins when #pinctrl-cells = 2

2020-09-23 Thread Tony Lindgren
* Trent Piepho [200924 01:34]: > On Tue, Sep 22, 2020 at 11:57 PM Tony Lindgren wrote: > > > > Also FYI, folks have also complained for a long time that the pinctrl-single > > binding mixes mux and conf values while they should be handled separately. > > > > Instead of combining two fields when

Re: [PATCH] ARM: dts: document pinctrl-single,pins when #pinctrl-cells = 2

2020-09-23 Thread Trent Piepho
On Tue, Sep 22, 2020 at 11:57 PM Tony Lindgren wrote: > > Also FYI, folks have also complained for a long time that the pinctrl-single > binding mixes mux and conf values while they should be handled separately. > Instead of combining two fields when the dts is generated they are now combined whe

Re: [PATCH] ARM: dts: document pinctrl-single,pins when #pinctrl-cells = 2

2020-09-22 Thread Tony Lindgren
* Drew Fustini [200914 10:44]: > Document the values in pinctrl-single,pins when #pinctrl-cells = <2> > > Fixes: 27c90e5e48d0 ("ARM: dts: am33xx-l4: change #pinctrl-cells from 1 to 2") > Reported-by: Trent Piepho > Link: https://lore.kernel.org/linux-omap/3139716.CMS8C0sQ7x@zen.local/ > Signed-o

Re: [PATCH] ARM: dts: document pinctrl-single,pins when #pinctrl-cells = 2

2020-09-22 Thread Tony Lindgren
* Drew Fustini [200917 10:39]: > On Thu, Sep 17, 2020 at 03:00:36AM -0700, Trent Piepho wrote: > > On Thu, Sep 17, 2020 at 2:20 AM Drew Fustini wrote: > > > > > > On Thu, Sep 17, 2020 at 02:03:46AM -0700, Trent Piepho wrote: > > > > On Mon, Sep 14, 2020 at 3:44 AM Drew Fustini > > > > wrote: >

Re: [PATCH] ARM: dts: document pinctrl-single,pins when #pinctrl-cells = 2

2020-09-17 Thread Drew Fustini
On Thu, Sep 17, 2020 at 03:00:36AM -0700, Trent Piepho wrote: > On Thu, Sep 17, 2020 at 2:20 AM Drew Fustini wrote: > > > > On Thu, Sep 17, 2020 at 02:03:46AM -0700, Trent Piepho wrote: > > > On Mon, Sep 14, 2020 at 3:44 AM Drew Fustini wrote: > > > > > > > > + > > > > +When #pinctrl-cells = 2, t

Re: [PATCH] ARM: dts: document pinctrl-single,pins when #pinctrl-cells = 2

2020-09-17 Thread Trent Piepho
On Thu, Sep 17, 2020 at 2:20 AM Drew Fustini wrote: > > On Thu, Sep 17, 2020 at 02:03:46AM -0700, Trent Piepho wrote: > > On Mon, Sep 14, 2020 at 3:44 AM Drew Fustini wrote: > > > > > > + > > > +When #pinctrl-cells = 2, then setting a pin for a device could be done > > > with: > > > + > > > +

Re: [PATCH] ARM: dts: document pinctrl-single,pins when #pinctrl-cells = 2

2020-09-17 Thread Drew Fustini
On Thu, Sep 17, 2020 at 02:03:46AM -0700, Trent Piepho wrote: > On Mon, Sep 14, 2020 at 3:44 AM Drew Fustini wrote: > > > > + > > +When #pinctrl-cells = 2, then setting a pin for a device could be done > > with: > > + > > + pinctrl-single,pins = <0xdc 0x30 0x07>; > > + > > +Where 0x30 is th

Re: [PATCH] ARM: dts: document pinctrl-single,pins when #pinctrl-cells = 2

2020-09-17 Thread Trent Piepho
On Mon, Sep 14, 2020 at 3:44 AM Drew Fustini wrote: > > + > +When #pinctrl-cells = 2, then setting a pin for a device could be done with: > + > + pinctrl-single,pins = <0xdc 0x30 0x07>; > + > +Where 0x30 is the pin configuration value and 0x07 is the pin mux mode value. > +See the device exa