Re: [PATCH] ASoC: soc-pcm: change error message to debug message

2021-02-10 Thread Mark Brown
On Mon, 8 Feb 2021 16:12:45 +0800, Shengjiu Wang wrote: > This log message should be a debug message, because it > doesn't return directly but continue next loop. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: soc-pcm: change error m

Re: [PATCH] ASoC: soc-pcm: change error message to debug message

2021-02-09 Thread Pierre-Louis Bossart
On 2/9/21 4:23 PM, Mark Brown wrote: On Mon, Feb 08, 2021 at 09:06:44AM -0600, Pierre-Louis Bossart wrote: If you demote this to dev_dbg, we'll have to ask every single user who reports 'sound is broken' to enable dynamic debug traces. I really don't see the benefit, this is a clear case of

Re: [PATCH] ASoC: soc-pcm: change error message to debug message

2021-02-09 Thread Mark Brown
On Mon, Feb 08, 2021 at 09:06:44AM -0600, Pierre-Louis Bossart wrote: > If you demote this to dev_dbg, we'll have to ask every single user who > reports 'sound is broken' to enable dynamic debug traces. I really don't see > the benefit, this is a clear case of 'fail big and fail early', partly > c

Re: [PATCH] ASoC: soc-pcm: change error message to debug message

2021-02-08 Thread Shengjiu Wang
On Tue, Feb 9, 2021 at 12:39 AM Pierre-Louis Bossart wrote: > > > > On 2/8/21 2:12 AM, Shengjiu Wang wrote: > > This log message should be a debug message, because it > > doesn't return directly but continue next loop. > > > > Signed-off-by: Shengjiu Wang > > --- > > sound/soc/soc-pcm.c | 4 ++-

Re: [PATCH] ASoC: soc-pcm: change error message to debug message

2021-02-08 Thread Pierre-Louis Bossart
On 2/8/21 2:12 AM, Shengjiu Wang wrote: This log message should be a debug message, because it doesn't return directly but continue next loop. Signed-off-by: Shengjiu Wang --- sound/soc/soc-pcm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/soc-pcm.c b