Re: [PATCH] Add an offset in the cyc2ns computation to fix sched_clock jumps

2007-03-18 Thread Guillaume Chazarain
2007/3/18, Mathieu Desnoyers <[EMAIL PROTECTED]>: Hi Guillaume, Hi Mathieu, thanks for your extensive reply. yet another level of band-aid over a I don't agree it's a band-aid, changing the scaling coefficient without adjusting an offset is a bug. broken architecture : AMD 7th and 8th gen

Re: [PATCH] Add an offset in the cyc2ns computation to fix sched_clock jumps

2007-03-18 Thread Mathieu Desnoyers
Hi Guillaume, I understand your need for a working system, but the impression I get is that this looks too much like yet another level of band-aid over a broken architecture : AMD 7th and 8th generations, which does not give a synchronized TSC. The patch you suggest may work for scheduler purpose

Re: [PATCH] Add an offset in the cyc2ns computation to fix sched_clock jumps

2007-03-16 Thread Guillaume Chazarain
2007/3/16, Andi Kleen <[EMAIL PROTECTED]>: I already fixed this myself in a similar way (but didn't push it out yet) Out of insatiable curiosity, I'd be interested in seeing what the patch looks like if you agree. Thanks. -- Guillaume - To unsubscribe from this list: send the line "unsubscrib

Re: [PATCH] Add an offset in the cyc2ns computation to fix sched_clock jumps

2007-03-16 Thread Guillaume Chazarain
2007/3/16, Daniel Walker <[EMAIL PROTECTED]>: Did you explain what the "werirdnes" was exactly? If not, could you? I didn't track these weirdnesses in the scheduler code, but the symptom is audio skipping and the mouse stops moving when the CPU becomes busy and the ondemand governor increases t

Re: [PATCH] Add an offset in the cyc2ns computation to fix sched_clock jumps

2007-03-16 Thread Andreas Kleen
Am Fr 16.03.2007 19:30 schrieb Daniel Walker <[EMAIL PROTECTED]>: > On Fri, 2007-03-16 at 19:14 +0100, Guillaume Chazarain wrote: > > Hello, > > > > The scheduling problems I reported in the thread: > > http://lkml.org/lkml/2007/3/3/128 > > are caused by the set_cyc2ns_scale() function called when

Re: [PATCH] Add an offset in the cyc2ns computation to fix sched_clock jumps

2007-03-16 Thread Daniel Walker
On Fri, 2007-03-16 at 19:14 +0100, Guillaume Chazarain wrote: > Hello, > > The scheduling problems I reported in the thread: > http://lkml.org/lkml/2007/3/3/128 > are caused by the set_cyc2ns_scale() function called when the CPU speed > changes. > Changing the scale causes a warp in the value ret

Re: [PATCH] Add an offset in the cyc2ns computation to fix sched_clock jumps

2007-03-16 Thread john stultz
On Fri, 2007-03-16 at 19:14 +0100, Guillaume Chazarain wrote: > Hello, > > The scheduling problems I reported in the thread: > http://lkml.org/lkml/2007/3/3/128 > are caused by the set_cyc2ns_scale() function called when the CPU speed > changes. > Changing the scale causes a warp in the value ret

Re: [PATCH] Add an offset in the cyc2ns computation to fix sched_clock jumps

2007-03-16 Thread Andi Kleen
On Friday 16 March 2007 19:14, Guillaume Chazarain wrote: > Hello, > > The scheduling problems I reported in the thread: > http://lkml.org/lkml/2007/3/3/128 > are caused by the set_cyc2ns_scale() function called when the CPU speed > changes. > Changing the scale causes a warp in the value returne