Re: [External] Re: [PATCH] Documentation: Add documentation for new platform_profile sysfs attribute

2020-10-29 Thread Bastien Nocera
On Thu, 2020-10-29 at 10:46 +0100, Hans de Goede wrote: > < > > IMHO it does not belong in the sysfs API docs for the > platform_profile > stuff. But I guess it would be good to document it somewhere in some > generic syfs API rules/expectations document (with a note that their > might be excepti

Re: [PATCH] Documentation: Add documentation for new platform_profile sysfs attribute

2020-10-29 Thread Bastien Nocera
On Wed, 2020-10-28 at 18:23 +0100, Hans de Goede wrote: > > > It's not meaningless, but rather ambiguous. For a range of 1 to 5, > > is 1 > > high performance, and 5 low power, or vice-versa? > > It is meaningless because the space we are trying to describe with > the > profile-names is not 1 dim

Re: [PATCH] Documentation: Add documentation for new platform_profile sysfs attribute

2020-10-29 Thread Rafael J. Wysocki
On Thu, Oct 29, 2020 at 2:53 AM Bastien Nocera wrote: > > Hey Hans, Mark, > > On Tue, 2020-10-27 at 12:42 -0400, Mark Pearson wrote: > > From: Hans de Goede > > > > On modern systems the platform performance, temperature, fan and > > other > > hardware related characteristics are often dynamicall

Re: [External] Re: [PATCH] Documentation: Add documentation for new platform_profile sysfs attribute

2020-10-29 Thread Hans de Goede
Hi, On 10/29/20 1:55 AM, Mark Pearson wrote: > Thanks Hans and Bastien, > > On 28/10/2020 13:23, Hans de Goede wrote: >>> Is there another file which explains whether those sysfs value will >>> contain a trailing linefeed? >> >> sysfs APIs are typically created so that they can be used from th

Re: [PATCH] Documentation: Add documentation for new platform_profile sysfs attribute

2020-10-28 Thread Hans de Goede
Hi, A few minor nitpicks below, mostly stuff which I missed before, sorry. I suggest you make v2 part of the series where you actually add the drivers/acpi/... and the thinkpad_acpi.c bits to implement this. On 10/27/20 5:42 PM, Mark Pearson wrote: > From: Hans de Goede > > On modern systems t

Re: [PATCH] Documentation: Add documentation for new platform_profile sysfs attribute

2020-10-28 Thread Bastien Nocera
Hey Hans, Mark, On Tue, 2020-10-27 at 12:42 -0400, Mark Pearson wrote: > From: Hans de Goede > > On modern systems the platform performance, temperature, fan and > other > hardware related characteristics are often dynamically configurable. > The > profile is often automatically adjusted to the

Re: [External] Re: [PATCH] Documentation: Add documentation for new platform_profile sysfs attribute

2020-10-28 Thread Mark Pearson
Thanks Hans and Bastien, On 28/10/2020 13:23, Hans de Goede wrote: Hi, On 10/28/20 2:45 PM, Bastien Nocera wrote: Hey Hans, Mark, On Tue, 2020-10-27 at 12:42 -0400, Mark Pearson wrote: From: Hans de Goede On modern systems the platform performance, temperature, fan and other hardware relat

Re: [PATCH] Documentation: Add documentation for new platform_profile sysfs attribute

2020-10-28 Thread Hans de Goede
Hi, On 10/28/20 2:45 PM, Bastien Nocera wrote: > Hey Hans, Mark, > > On Tue, 2020-10-27 at 12:42 -0400, Mark Pearson wrote: >> From: Hans de Goede >> >> On modern systems the platform performance, temperature, fan and >> other >> hardware related characteristics are often dynamically configurabl

Re: [PATCH] Documentation: Add documentation for new platform_profile sysfs attribute

2020-10-27 Thread Elia Devito
Hi to all, In data martedì 27 ottobre 2020 17:42:19 CET, Mark Pearson ha scritto: > From: Hans de Goede > > On modern systems the platform performance, temperature, fan and other > hardware related characteristics are often dynamically configurable. The > profile is often automatically adjusted