Re: [PATCH] Factor out common MODULE_INFO content from module*.h files.

2007-05-21 Thread Robert P. J. Day
On Mon, 21 May 2007, Sam Ravnborg wrote: > rday wrote: > > under the circumstances, is there *any* cleanup worth doing WRT to > > this issue? because of the fact that module.h currently includes > > moduleparam.h, developers have been able to get away with being > > incredibly sloppy in their in

Re: [PATCH] Factor out common MODULE_INFO content from module*.h files.

2007-05-20 Thread Sam Ravnborg
> > under the circumstances, is there *any* cleanup worth doing WRT to > this issue? because of the fact that module.h currently includes > moduleparam.h, developers have been able to get away with being > incredibly sloppy in their includes. It is wortwhile to make module.h independent of modul

Re: [PATCH] Factor out common MODULE_INFO content from module*.h files.

2007-05-20 Thread Robert P. J. Day
On Sun, 20 May 2007, Sam Ravnborg wrote: > On Sun, May 20, 2007 at 04:06:40PM -0400, Robert P. J. Day wrote: > > On Sun, 20 May 2007, Sam Ravnborg wrote: > > > > > On Sun, May 20, 2007 at 03:06:15PM -0400, Robert P. J. Day wrote: > > > > > > > > In order to eventually break the interdependency bet

Re: [PATCH] Factor out common MODULE_INFO content from module*.h files.

2007-05-20 Thread Sam Ravnborg
On Sun, May 20, 2007 at 04:06:40PM -0400, Robert P. J. Day wrote: > On Sun, 20 May 2007, Sam Ravnborg wrote: > > > On Sun, May 20, 2007 at 03:06:15PM -0400, Robert P. J. Day wrote: > > > > > > In order to eventually break the interdependency between the module.h > > > and moduleparam.h header file

Re: [PATCH] Factor out common MODULE_INFO content from module*.h files.

2007-05-20 Thread Sam Ravnborg
On Sun, May 20, 2007 at 03:51:18PM -0400, Robert P. J. Day wrote: > On Sun, 20 May 2007, Sam Ravnborg wrote: > > > On Sun, May 20, 2007 at 03:06:15PM -0400, Robert P. J. Day wrote: > > > > > > In order to eventually break the interdependency between the module.h > > > and moduleparam.h header file

Re: [PATCH] Factor out common MODULE_INFO content from module*.h files.

2007-05-20 Thread Robert P. J. Day
On Sun, 20 May 2007, Sam Ravnborg wrote: > On Sun, May 20, 2007 at 03:06:15PM -0400, Robert P. J. Day wrote: > > > > In order to eventually break the interdependency between the module.h > > and moduleparam.h header files, factor out the common MODULE_INFO > > content into a new header file. > > T

Re: [PATCH] Factor out common MODULE_INFO content from module*.h files.

2007-05-20 Thread Robert P. J. Day
On Sun, 20 May 2007, Sam Ravnborg wrote: > On Sun, May 20, 2007 at 03:06:15PM -0400, Robert P. J. Day wrote: > > > > In order to eventually break the interdependency between the module.h > > and moduleparam.h header files, factor out the common MODULE_INFO > > content into a new header file. > > T

Re: [PATCH] Factor out common MODULE_INFO content from module*.h files.

2007-05-20 Thread Sam Ravnborg
On Sun, May 20, 2007 at 03:06:15PM -0400, Robert P. J. Day wrote: > > In order to eventually break the interdependency between the module.h > and moduleparam.h header files, factor out the common MODULE_INFO > content into a new header file. The moduleinfo.h file looks redundant at first look. Wh