Re: [PATCH] Fix faulty logic in the case of recursive printk

2014-08-27 Thread Petr Mládek
On Tue 26-08-14 07:23:22, Patrick Palka wrote: > Thanks for reviewing! I have put back the call to strlen() and adjusted > the commit message accordingly. > > Patrick > > -- >8 -- > > We shouldn't set text_len in the code path that detects printk recursion > because text_len corresponds to the

Re: [PATCH] Fix faulty logic in the case of recursive printk

2014-08-26 Thread Steven Rostedt
On Tue, 26 Aug 2014 11:19:41 +0200 Petr Mládek wrote: > On Sun 24-08-14 12:01:36, Patrick Palka wrote: > > We shouldn't set text_len in the code path that detects printk recursion > > because text_len corresponds to the length of the string inside textbuf. > > A few lines down from the line > >

Re: [PATCH] Fix faulty logic in the case of recursive printk

2014-08-26 Thread Jan Kara
On Tue 26-08-14 07:23:22, Patrick Palka wrote: > Thanks for reviewing! I have put back the call to strlen() and adjusted > the commit message accordingly. > > Patrick > > -- >8 -- > > We shouldn't set text_len in the code path that detects printk recursion > because text_len corresponds to the

Re: [PATCH] Fix faulty logic in the case of recursive printk

2014-08-26 Thread Petr Mládek
On Sun 24-08-14 12:01:36, Patrick Palka wrote: > We shouldn't set text_len in the code path that detects printk recursion > because text_len corresponds to the length of the string inside textbuf. > A few lines down from the line > > text_len = strlen(recursion_msg); > > is the line > >

Re: [PATCH] Fix faulty logic in the case of recursive printk

2014-08-26 Thread Jan Kara
On Sun 24-08-14 12:01:36, Patrick Palka wrote: > We shouldn't set text_len in the code path that detects printk recursion > because text_len corresponds to the length of the string inside textbuf. > A few lines down from the line > > text_len = strlen(recursion_msg); > > is the line > >