Re: [PATCH] HID: core: move Usage Page concatenation to hid_parser_main()

2019-03-25 Thread Nicolas Saenz Julienne
Hi Benjamin, Thanks for the review! On Mon, 2019-03-25 at 16:08 +0100, Benjamin Tissoires wrote: > On Mon, Mar 25, 2019 at 11:39 AM Benjamin Tissoires > wrote: > > Hi Nicolas, > > > > On Tue, Mar 12, 2019 at 10:37 AM Nicolas Saenz Julienne > > wrote: > > > As seen on some USB wireless keyboards

Re: [PATCH] HID: core: move Usage Page concatenation to hid_parser_main()

2019-03-25 Thread Benjamin Tissoires
On Mon, Mar 25, 2019 at 11:39 AM Benjamin Tissoires wrote: > > Hi Nicolas, > > On Tue, Mar 12, 2019 at 10:37 AM Nicolas Saenz Julienne > wrote: > > > > As seen on some USB wireless keyboards manufactured by Primax, the HID > > parser was using some assumptions that are not always true. In this ca

Re: [PATCH] HID: core: move Usage Page concatenation to hid_parser_main()

2019-03-25 Thread Benjamin Tissoires
Hi Nicolas, On Tue, Mar 12, 2019 at 10:37 AM Nicolas Saenz Julienne wrote: > > As seen on some USB wireless keyboards manufactured by Primax, the HID > parser was using some assumptions that are not always true. In this case > it's s the fact that, inside the scope of a main item, an Usage Page >