Re: [PATCH] I2C: JZ4780: Fix bug for Ingenic X1000.

2021-04-02 Thread Zhou Yanjie
Hi Wolfram, On 2021/3/31 下午3:18, Wolfram Sang wrote: Hi, Any write operation? I wonder then why nobody noticed before? The standard I2C communication should look like this: Read: device_addr + w, reg_addr, device_addr + r, data; Write: device_addr + w, reg_addr, data; But without this

Re: [PATCH] I2C: JZ4780: Fix bug for Ingenic X1000.

2021-03-31 Thread Wolfram Sang
Hi, > > Any write operation? I wonder then why nobody noticed before? > > > The standard I2C communication should look like this: > > Read: > > device_addr + w, reg_addr, device_addr + r, data; > > Write: > > device_addr + w, reg_addr, data; > > > But without this patch, it looks like thi

Re: [PATCH] I2C: JZ4780: Fix bug for Ingenic X1000.

2021-03-18 Thread Zhou Yanjie
Hi Wolfram, Sorry, please forgive my carefulness, I wrongly sent the version that did not clean up, resulting in missing the reporter's information and some errors in formats. On 2021/3/19 上午1:06, Wolfram Sang wrote: On Fri, Mar 19, 2021 at 12:25:43AM +0800, 周琰杰 (Zhou Yanjie) wrote: Only

Re: [PATCH] I2C: JZ4780: Fix bug for Ingenic X1000.

2021-03-18 Thread Wolfram Sang
On Fri, Mar 19, 2021 at 12:25:43AM +0800, 周琰杰 (Zhou Yanjie) wrote: > Only send "X1000_I2C_DC_STOP" when last byte, or it will cause > error when I2C write operation. Any write operation? I wonder then why nobody noticed before? > - while ((i2c_sta & JZ4780_I2C_STA_TFNF) && > -

Re: [PATCH] I2C: JZ4780: Fix bug for Ingenic X1000.

2021-03-18 Thread Greg KH
On Fri, Mar 19, 2021 at 12:25:43AM +0800, 周琰杰 (Zhou Yanjie) wrote: > Only send "X1000_I2C_DC_STOP" when last byte, or it will cause > error when I2C write operation. > > Fixes: 21575a7a8d4c ("I2C: JZ4780: Add support for the X1000.") > > Signed-off-by: 周琰杰 (Zhou Yanjie) > --- > drivers/i2c/buss