Re: [PATCH] Input: adp5588-keys: cancel workqueue in failure path

2014-10-08 Thread Pramod Gurav
On Wed, Oct 8, 2014 at 3:48 PM, Pramod Gurav wrote: > Hi Dmitry, > > On Tue, Oct 7, 2014 at 10:08 PM, Dmitry Torokhov > .. > Thanks. I saw the change in your tree. Shouldn't > cancel_delayed_work_sync(&kpad->work) be called under label > err_free_mem so that it will executed in case adp5588_read

Re: [PATCH] Input: adp5588-keys: cancel workqueue in failure path

2014-10-08 Thread Pramod Gurav
Hi Dmitry, On Tue, Oct 7, 2014 at 10:08 PM, Dmitry Torokhov wrote: > On Tue, Oct 07, 2014 at 01:00:49PM +0530, Pramod Gurav wrote: >> This change introduces a label to call cancel_delayed_work_sync in >> failure path. >> >> Cc: Michael Hennerich >> Cc: Dmitry Torokhov >> Cc: linux-in...@vger.ke

Re: [PATCH] Input: adp5588-keys: cancel workqueue in failure path

2014-10-07 Thread Dmitry Torokhov
On Tue, Oct 07, 2014 at 01:00:49PM +0530, Pramod Gurav wrote: > This change introduces a label to call cancel_delayed_work_sync in > failure path. > > Cc: Michael Hennerich > Cc: Dmitry Torokhov > Cc: linux-in...@vger.kernel.org > Signed-off-by: Pramod Gurav > --- > drivers/input/keyboard/adp5

Re: [PATCH] Input: adp5588-keys: cancel workqueue in failure path

2014-10-07 Thread Michael Hennerich
On 10/07/2014 09:30 AM, Pramod Gurav wrote: This change introduces a label to call cancel_delayed_work_sync in failure path. Cc: Michael Hennerich Cc: Dmitry Torokhov Cc: linux-in...@vger.kernel.org Signed-off-by: Pramod Gurav The interrupt triggers the work queue. adp5588_setup() enable th