Re: [PATCH] Input: applespi: Fix build error without CONFIG_PCI

2019-07-18 Thread Randy Dunlap
On 7/18/19 4:40 AM, Life is hard, and then you die wrote: > > On Thu, Jul 18, 2019 at 10:06:54AM +0800, YueHaibing wrote: >> If CONFIG_KEYBOARD_APPLESPI is set to y, but >> CONFIG_PCI is not set, building will fails: >> >> drivers/spi/spi-pxa2xx-pci.c: In function pxa2xx_spi_pci_probe: >> drivers/

Re: [PATCH] Input: applespi: Fix build error without CONFIG_PCI

2019-07-18 Thread Arnd Bergmann
On Thu, Jul 18, 2019 at 1:58 PM Life is hard, and then you die wrote: > On Thu, Jul 18, 2019 at 09:15:59AM +0200, Arnd Bergmann wrote: > > On Thu, Jul 18, 2019 at 4:07 AM YueHaibing wrote: > > Your patch correctly solves the spi_pxa2xx issue, but I'd prefer to instead > > drop the three 'imply' s

Re: [PATCH] Input: applespi: Fix build error without CONFIG_PCI

2019-07-18 Thread Life is hard, and then you die
Hi Arnd, On Thu, Jul 18, 2019 at 09:15:59AM +0200, Arnd Bergmann wrote: > On Thu, Jul 18, 2019 at 4:07 AM YueHaibing wrote: > > > > If CONFIG_KEYBOARD_APPLESPI is set to y, but > > CONFIG_PCI is not set, building will fails: > > > > drivers/spi/spi-pxa2xx-pci.c: In function pxa2xx_spi_pci_pro

Re: [PATCH] Input: applespi: Fix build error without CONFIG_PCI

2019-07-18 Thread Arnd Bergmann
On Thu, Jul 18, 2019 at 1:40 PM Life is hard, and then you die wrote: > On Thu, Jul 18, 2019 at 10:06:54AM +0800, YueHaibing wrote: > > @@ -74,7 +74,7 @@ config ATARI_KBD_CORE > > config KEYBOARD_APPLESPI > > tristate "Apple SPI keyboard and trackpad" > > depends on ACPI && EFI > > -

Re: [PATCH] Input: applespi: Fix build error without CONFIG_PCI

2019-07-18 Thread Life is hard, and then you die
On Thu, Jul 18, 2019 at 10:06:54AM +0800, YueHaibing wrote: > If CONFIG_KEYBOARD_APPLESPI is set to y, but > CONFIG_PCI is not set, building will fails: > > drivers/spi/spi-pxa2xx-pci.c: In function pxa2xx_spi_pci_probe: > drivers/spi/spi-pxa2xx-pci.c:208:8: error: implicit declaration of functi

Re: [PATCH] Input: applespi: Fix build error without CONFIG_PCI

2019-07-18 Thread Arnd Bergmann
On Thu, Jul 18, 2019 at 4:07 AM YueHaibing wrote: > > If CONFIG_KEYBOARD_APPLESPI is set to y, but > CONFIG_PCI is not set, building will fails: > > drivers/spi/spi-pxa2xx-pci.c: In function pxa2xx_spi_pci_probe: > drivers/spi/spi-pxa2xx-pci.c:208:8: error: implicit declaration of function > pcim