Re: [PATCH] MODSIGN: Warn when module signature checking fails

2013-01-21 Thread Rusty Russell
Chris Samuel writes: > /* Please CC me, I'm not on LKML */ > > On 21/01/13 10:36, Rusty Russell wrote: > >> We have errnos for a reason; let's not pollute the kernel logs. That's >> a userspace job. > > Fair enough. > >> This part is OK, but I'll add mod->name to the printk. > > Sounds good. > >>

Re: [PATCH] MODSIGN: Warn when module signature checking fails

2013-01-21 Thread Chris Samuel
/* Please CC me, I'm not on LKML */ On 21/01/13 10:36, Rusty Russell wrote: > We have errnos for a reason; let's not pollute the kernel logs. That's > a userspace job. Fair enough. > This part is OK, but I'll add mod->name to the printk. Sounds good. > How's this: Looks fine, modulo the lac

Re: [PATCH] MODSIGN: Warn when module signature checking fails

2013-01-20 Thread Rusty Russell
Stephen Rothwell writes: > Hi Rusty, > > On Mon, 21 Jan 2013 10:06:11 +1030 Rusty Russell > wrote: >> >> #ifdef CONFIG_MODULE_SIG >> mod->sig_ok = info->sig_ok; >> -if (!mod->sig_ok) >> +if (!mod->sig_ok) { >> +printk_once(KERN_NOTICE >> +"%s: m

Re: [PATCH] MODSIGN: Warn when module signature checking fails

2013-01-20 Thread Stephen Rothwell
Hi Rusty, On Mon, 21 Jan 2013 10:06:11 +1030 Rusty Russell wrote: > > #ifdef CONFIG_MODULE_SIG > mod->sig_ok = info->sig_ok; > - if (!mod->sig_ok) > + if (!mod->sig_ok) { > + printk_once(KERN_NOTICE > + "%s: module verification failed: signature

Re: [PATCH] MODSIGN: Warn when module signature checking fails

2013-01-20 Thread Rusty Russell
Chris Samuel writes: > /* Please CC me, I'm not on LKML */ > > * Reworked from the original patch based on feedback from Josh Boyer > * (putting the code in load_module()) and Rusty Russel (use > * KERN_NOTICE). Extended to cover the other failure modes. We have errnos for a reason; let's not po