Re: [PATCH] Module use count must be updated as bridges are created/destroyed

2007-09-28 Thread Herbert Xu
On Fri, Sep 28, 2007 at 11:11:07AM -0700, Stephen Hemminger wrote: > > It is only the nested removal problem. Well such a count could apply to direct removals too. In other words, you could ask modprobe to remove all modules for which this count is zero. Cheers, -- Visit Openswan at http://www.

Re: [PATCH] Module use count must be updated as bridges are created/destroyed

2007-09-28 Thread Stephen Hemminger
On Fri, 28 Sep 2007 13:37:39 +0800 Herbert Xu <[EMAIL PROTECTED]> wrote: > Jan Beulich <[EMAIL PROTECTED]> wrote: > > > > So we have an unsolvable problem here then, unless infrastructure gets added > > that allows a module to declare itself as not-implicit-unload-safe, forcing > > modprobe -r to

Re: [PATCH] Module use count must be updated as bridges are created/destroyed

2007-09-27 Thread Herbert Xu
Jan Beulich <[EMAIL PROTECTED]> wrote: > > So we have an unsolvable problem here then, unless infrastructure gets added > that allows a module to declare itself as not-implicit-unload-safe, forcing > modprobe -r to keep its hands off it. Ugly. Yes I've always wanted to have a separate count that i

Re: [PATCH] Module use count must be updated as bridges are created/destroyed

2007-09-27 Thread Jan Beulich
>> >Sounds like a module utilities problem since unloading one module doesn't >> >normally unload others. >> >> I have to disagree here - 'modprobe -r' is specifically unloading all >> modules the >> specified one references as long as they have a use count of zero. The >> difference to other net

Re: why network devices don't do reference counting? (Re: [PATCH] Module use count must be updated as bridges are created/destroyed)

2007-09-27 Thread Jan Engelhardt
On Sep 27 2007 07:51, Stephen Hemminger wrote: > >You need every socket to close and all routes to go away including the >routes through loopback device, and still there probably are control >sockets buried inside ipv6 that hold ref count. > >IMHO the kernel should just admit that IPV6 can't be

Re: why network devices don't do reference counting? (Re: [PATCH] Module use count must be updated as bridges are created/destroyed)

2007-09-27 Thread Stephen Hemminger
On Thu, 27 Sep 2007 13:54:23 +0200 Helge Hafting <[EMAIL PROTECTED]> wrote: > Stephen Hemminger wrote: > > On Thu, 27 Sep 2007 00:18:55 +0200 (CEST) > > Jan Engelhardt <[EMAIL PROTECTED]> wrote: > > > > > >> On Sep 26 2007 14:06, Stephen Hemminger wrote: > >> > > No, network devices do

Re: [PATCH] Module use count must be updated as bridges are created/destroyed

2007-09-27 Thread Stephen Hemminger
On Thu, 27 Sep 2007 08:40:10 +0100 "Jan Beulich" <[EMAIL PROTECTED]> wrote: > >>> Stephen Hemminger <[EMAIL PROTECTED]> 26.09.07 19:12 >>> > >On Wed, 26 Sep 2007 17:08:19 +0100 > >"Jan Beulich" <[EMAIL PROTECTED]> wrote: > > > >> >>> Stephen Hemminger <[EMAIL PROTECTED]> 26.09.07 17:37 >>> > >> >O

Re: why network devices don't do reference counting? (Re: [PATCH] Module use count must be updated as bridges are created/destroyed)

2007-09-27 Thread Helge Hafting
Stephen Hemminger wrote: On Thu, 27 Sep 2007 00:18:55 +0200 (CEST) Jan Engelhardt <[EMAIL PROTECTED]> wrote: On Sep 26 2007 14:06, Stephen Hemminger wrote: No, network devices don't do reference counting. Could you explain why, please? After `udevd` on boot loads lots of u

Re: [PATCH] Module use count must be updated as bridges are created/destroyed

2007-09-27 Thread Jan Beulich
>>> Stephen Hemminger <[EMAIL PROTECTED]> 26.09.07 19:12 >>> >On Wed, 26 Sep 2007 17:08:19 +0100 >"Jan Beulich" <[EMAIL PROTECTED]> wrote: > >> >>> Stephen Hemminger <[EMAIL PROTECTED]> 26.09.07 17:37 >>> >> >On Wed, 26 Sep 2007 08:53:27 +0100 >> >"Jan Beulich" <[EMAIL PROTECTED]> wrote: >> > >> >>

Re: why network devices don't do reference counting? (Re: [PATCH] Module use count must be updated as bridges are created/destroyed)

2007-09-26 Thread Stephen Hemminger
On Thu, 27 Sep 2007 00:18:55 +0200 (CEST) Jan Engelhardt <[EMAIL PROTECTED]> wrote: > > On Sep 26 2007 14:06, Stephen Hemminger wrote: > >> > > >> > No, network devices don't do reference counting. > >> > >> Could you explain why, please? > >> > >> After `udevd` on boot loads lots of unused cra

Re: why network devices don't do reference counting? (Re: [PATCH] Module use count must be updated as bridges are created/destroyed)

2007-09-26 Thread Jan Engelhardt
On Sep 26 2007 14:06, Stephen Hemminger wrote: >> > >> > No, network devices don't do reference counting. >> >> Could you explain why, please? >> >> After `udevd` on boot loads lots of unused crap, i surrendered, and use >> $(rmmod `lsmod | just first column`). Networing bravely wipes away. OK,

Re: why network devices don't do reference counting? (Re: [PATCH] Module use count must be updated as bridges are created/destroyed)

2007-09-26 Thread Stephen Hemminger
On Wed, 26 Sep 2007 23:06:53 +0200 Oleg Verych <[EMAIL PROTECTED]> wrote: > * Wed, 26 Sep 2007 08:37:05 -0700 > * Organization: Linux Foundation > > > > On Wed, 26 Sep 2007 08:53:27 +0100 > > "Jan Beulich" <[EMAIL PROTECTED]> wrote: > > > >> Otherwise 'modprobe -r' on a module having a dependency

why network devices don't do reference counting? (Re: [PATCH] Module use count must be updated as bridges are created/destroyed)

2007-09-26 Thread Oleg Verych
* Wed, 26 Sep 2007 08:37:05 -0700 * Organization: Linux Foundation > > On Wed, 26 Sep 2007 08:53:27 +0100 > "Jan Beulich" <[EMAIL PROTECTED]> wrote: > >> Otherwise 'modprobe -r' on a module having a dependency on bridge will >> implicitly unload bridge, bringing down all connectivity that was >> us

Re: [PATCH] Module use count must be updated as bridges are created/destroyed

2007-09-26 Thread Stephen Hemminger
On Wed, 26 Sep 2007 08:53:27 +0100 "Jan Beulich" <[EMAIL PROTECTED]> wrote: > Otherwise 'modprobe -r' on a module having a dependency on bridge will > implicitly unload bridge, bringing down all connectivity that was > using bridges. > > Signed-off-by: Jan Beulich <[EMAIL PROTECTED]> > No, netwo