Re: [PATCH] More network pci_enable cleanups.

Em Sun, Feb 11, 2001 at 07:12:15AM -0500, Jeff Garzik escreveu: > [EMAIL PROTECTED] wrote: > > > > - int cards_found = 0; > > > > + int cards_found; > > > Rejected. Introduces bug. That zero is required! > > > > Refresh my memory here. I thought unitialised vars go to bss, >

Re: [PATCH] More network pci_enable cleanups.

[EMAIL PROTECTED] wrote: > > > - int cards_found = 0; > > > + int cards_found; > > Rejected. Introduces bug. That zero is required! > > Refresh my memory here. I thought unitialised vars go to bss, > and get zeroed at boot time ? cards_found is on the stack, which can conta

Re: [PATCH] More network pci_enable cleanups.

On Sat, 10 Feb 2001, Jeff Garzik wrote: > 1) Bug: Introduced memory leak by replacing "goto err_out" with "return > err" > 2) Sole usage of 'err' -- it should be scoped inside the pdev!=NULL > check. Will fix up later. > > - int cards_found = 0; > > + int cards_found; > Reje

Re: [PATCH] More network pci_enable cleanups.

[EMAIL PROTECTED] wrote: > diff -urN --exclude-from=/home/davej/.exclude linux/drivers/net/defxx.c >linux-dj/drivers/net/defxx.c > --- linux/drivers/net/defxx.c Sat Feb 10 02:49:43 2001 > +++ linux-dj/drivers/net/defxx.cSat Feb 10 03:05:03 2001 > @@ -414,6 +415,7 @@ > struct net