Re: [PATCH] PCI/shpchp: fix a bus speed issue on hotplug

2014-05-17 Thread Michael S. Tsirkin
On Thu, May 15, 2014 at 12:41:46PM -0600, Bjorn Helgaas wrote: > On Thu, May 01, 2014 at 05:35:48PM +0300, Marcel Apfelbaum wrote: > > When a board is added, the shpchp driver checks if there > > is a mismatch between the bridge's adapter and the bus speed. > > If there is, it sets the subordinate

Re: [PATCH] PCI/shpchp: fix a bus speed issue on hotplug

2014-05-15 Thread Bjorn Helgaas
On Thu, May 01, 2014 at 05:35:48PM +0300, Marcel Apfelbaum wrote: > When a board is added, the shpchp driver checks if there > is a mismatch between the bridge's adapter and the bus speed. > If there is, it sets the subordinate speed (if there is no device on it). > > However, it takes the referen

Re: [PATCH] PCI/shpchp: fix a bus speed issue on hotplug

2014-05-04 Thread Marcel Apfelbaum
On Sun, 2014-05-04 at 16:48 +0300, Ronen Hod wrote: > On 05/01/2014 05:35 PM, Marcel Apfelbaum wrote: > > When a board is added, the shpchp driver checks if there > > is a mismatch between the bridge's adapter and the bus speed. > > If there is, it sets the subordinate speed (if there is no device

Re: [PATCH] PCI/shpchp: fix a bus speed issue on hotplug

2014-05-04 Thread Ronen Hod
On 05/01/2014 05:35 PM, Marcel Apfelbaum wrote: When a board is added, the shpchp driver checks if there is a mismatch between the bridge's adapter and the bus speed. If there is, it sets the subordinate speed (if there is no device on it). Since the speed is irrelevant when running in a VM, I

Re: [PATCH] PCI/shpchp: fix a bus speed issue on hotplug

2014-05-04 Thread Marcel Apfelbaum
On Thu, 2014-05-01 at 14:00 -0600, Bjorn Helgaas wrote: > On Thu, May 1, 2014 at 12:57 PM, Marcel Apfelbaum > wrote: > > On Thu, 2014-05-01 at 21:13 +0300, Marcel Apfelbaum wrote: > >> On Thu, 2014-05-01 at 12:02 -0600, Bjorn Helgaas wrote: > >> > On Thu, May 1, 2014 at 8:35 AM, Marcel Apfelbaum

Re: [PATCH] PCI/shpchp: fix a bus speed issue on hotplug

2014-05-01 Thread Marcel Apfelbaum
On Thu, 2014-05-01 at 14:00 -0600, Bjorn Helgaas wrote: > On Thu, May 1, 2014 at 12:57 PM, Marcel Apfelbaum > wrote: > > On Thu, 2014-05-01 at 21:13 +0300, Marcel Apfelbaum wrote: > >> On Thu, 2014-05-01 at 12:02 -0600, Bjorn Helgaas wrote: > >> > On Thu, May 1, 2014 at 8:35 AM, Marcel Apfelbaum

Re: [PATCH] PCI/shpchp: fix a bus speed issue on hotplug

2014-05-01 Thread Bjorn Helgaas
On Thu, May 1, 2014 at 12:57 PM, Marcel Apfelbaum wrote: > On Thu, 2014-05-01 at 21:13 +0300, Marcel Apfelbaum wrote: >> On Thu, 2014-05-01 at 12:02 -0600, Bjorn Helgaas wrote: >> > On Thu, May 1, 2014 at 8:35 AM, Marcel Apfelbaum >> > wrote: >> > > When a board is added, the shpchp driver check

Re: [PATCH] PCI/shpchp: fix a bus speed issue on hotplug

2014-05-01 Thread Marcel Apfelbaum
On Thu, 2014-05-01 at 21:13 +0300, Marcel Apfelbaum wrote: > On Thu, 2014-05-01 at 12:02 -0600, Bjorn Helgaas wrote: > > On Thu, May 1, 2014 at 8:35 AM, Marcel Apfelbaum > > wrote: > > > When a board is added, the shpchp driver checks if there > > > is a mismatch between the bridge's adapter and

Re: [PATCH] PCI/shpchp: fix a bus speed issue on hotplug

2014-05-01 Thread Marcel Apfelbaum
On Thu, 2014-05-01 at 12:02 -0600, Bjorn Helgaas wrote: > On Thu, May 1, 2014 at 8:35 AM, Marcel Apfelbaum wrote: > > When a board is added, the shpchp driver checks if there > > is a mismatch between the bridge's adapter and the bus speed. > > If there is, it sets the subordinate speed (if there

Re: [PATCH] PCI/shpchp: fix a bus speed issue on hotplug

2014-05-01 Thread Bjorn Helgaas
On Thu, May 1, 2014 at 8:35 AM, Marcel Apfelbaum wrote: > When a board is added, the shpchp driver checks if there > is a mismatch between the bridge's adapter and the bus speed. > If there is, it sets the subordinate speed (if there is no device on it). > > However, it takes the reference of the

Re: [PATCH] PCI/shpchp: fix a bus speed issue on hotplug

2014-05-01 Thread Michael S. Tsirkin
On Thu, May 01, 2014 at 05:35:48PM +0300, Marcel Apfelbaum wrote: > When a board is added, the shpchp driver checks if there > is a mismatch between the bridge's adapter and the bus speed. > If there is, it sets the subordinate speed (if there is no device on it). > > However, it takes the referen