Re: [PATCH] PCI: ACPI: Fix ThunderX PEM initialization

2017-03-23 Thread Jon Masters
Thanks :) :) :) -- Computer Architect | Sent from my 64-bit #ARM Powered phone > On Mar 23, 2017, at 18:14, Bjorn Helgaas wrote: > >> On Wed, Mar 22, 2017 at 11:34:00AM -0500, Bjorn Helgaas wrote: >>> On Wed, Mar 22, 2017 at 12:25:39PM -0400, Jon Masters wrote: On 03/22/2017 10:48 AM, Bjo

Re: [PATCH] PCI: ACPI: Fix ThunderX PEM initialization

2017-03-23 Thread Bjorn Helgaas
On Wed, Mar 22, 2017 at 11:34:00AM -0500, Bjorn Helgaas wrote: > On Wed, Mar 22, 2017 at 12:25:39PM -0400, Jon Masters wrote: > > On 03/22/2017 10:48 AM, Bjorn Helgaas wrote: > > > On Wed, Mar 22, 2017 at 10:28:27AM -0400, Jon Masters wrote: > > >> On 03/21/2017 10:56 AM, David Daney wrote: > > >

Re: [PATCH] PCI: ACPI: Fix ThunderX PEM initialization

2017-03-22 Thread Bjorn Helgaas
On Wed, Mar 22, 2017 at 12:25:39PM -0400, Jon Masters wrote: > On 03/22/2017 10:48 AM, Bjorn Helgaas wrote: > > On Wed, Mar 22, 2017 at 10:28:27AM -0400, Jon Masters wrote: > >> On 03/21/2017 10:56 AM, David Daney wrote: > > > >>> Yes. After all this back and forth, Cavium has decided to deploy >

Re: [PATCH] PCI: ACPI: Fix ThunderX PEM initialization

2017-03-22 Thread Jon Masters
On 03/22/2017 10:48 AM, Bjorn Helgaas wrote: > On Wed, Mar 22, 2017 at 10:28:27AM -0400, Jon Masters wrote: >> On 03/21/2017 10:56 AM, David Daney wrote: > >>> Yes. After all this back and forth, Cavium has decided to deploy >>> firmware with "CAVxxx" as _HID. >> >> Great. How about a stable back

Re: [PATCH] PCI: ACPI: Fix ThunderX PEM initialization

2017-03-22 Thread Bjorn Helgaas
On Wed, Mar 22, 2017 at 10:28:27AM -0400, Jon Masters wrote: > On 03/21/2017 10:56 AM, David Daney wrote: > > Yes. After all this back and forth, Cavium has decided to deploy > > firmware with "CAVxxx" as _HID. > > Great. How about a stable backport for Greg K-H? I want to make sure > that every

Re: [PATCH] PCI: ACPI: Fix ThunderX PEM initialization

2017-03-22 Thread Jon Masters
On 03/21/2017 10:56 AM, David Daney wrote: > On 03/21/2017 07:17 AM, Tomasz Nowicki wrote: >> On 21.03.2017 14:47, Bjorn Helgaas wrote: And for other folks following along with this thread: I'm not just picking on Cavium here. I'll be doing the same with *every* ARM server SoC comp

Re: [PATCH] PCI: ACPI: Fix ThunderX PEM initialization

2017-03-21 Thread Bjorn Helgaas
On Tue, Mar 21, 2017 at 03:17:17PM +0100, Tomasz Nowicki wrote: > Hi Bjorn, > > On 21.03.2017 14:47, Bjorn Helgaas wrote: > >On Tue, Mar 21, 2017 at 07:38:07AM -0400, Jon Masters wrote: > >>On 03/16/2017 12:25 PM, David Daney wrote: > >>>On 03/16/2017 07:32 AM, Jon Masters wrote: > >> > >Yes,

Re: [PATCH] PCI: ACPI: Fix ThunderX PEM initialization

2017-03-21 Thread David Daney
On 03/21/2017 07:17 AM, Tomasz Nowicki wrote: Hi Bjorn, On 21.03.2017 14:47, Bjorn Helgaas wrote: On Tue, Mar 21, 2017 at 07:38:07AM -0400, Jon Masters wrote: On 03/16/2017 12:25 PM, David Daney wrote: On 03/16/2017 07:32 AM, Jon Masters wrote: Yes, it is now contains "CAVxxx" as _HID for

Re: [PATCH] PCI: ACPI: Fix ThunderX PEM initialization

2017-03-21 Thread Tomasz Nowicki
Hi Bjorn, On 21.03.2017 14:47, Bjorn Helgaas wrote: On Tue, Mar 21, 2017 at 07:38:07AM -0400, Jon Masters wrote: On 03/16/2017 12:25 PM, David Daney wrote: On 03/16/2017 07:32 AM, Jon Masters wrote: Yes, it is now contains "CAVxxx" as _HID for device config object. Which is different from

Re: [PATCH] PCI: ACPI: Fix ThunderX PEM initialization

2017-03-21 Thread Bjorn Helgaas
On Tue, Mar 21, 2017 at 07:38:07AM -0400, Jon Masters wrote: > On 03/16/2017 12:25 PM, David Daney wrote: > > On 03/16/2017 07:32 AM, Jon Masters wrote: > > >>> Yes, it is now contains "CAVxxx" as _HID for device config object. > >> > >> Which is different from the version that was merged into ups

Re: [PATCH] PCI: ACPI: Fix ThunderX PEM initialization

2017-03-21 Thread Jon Masters
On 03/16/2017 12:25 PM, David Daney wrote: > On 03/16/2017 07:32 AM, Jon Masters wrote: >>> Yes, it is now contains "CAVxxx" as _HID for device config object. >> >> Which is different from the version that was merged into upstream. That >> should never have happened. It will never happen again. I

Re: [PATCH] PCI: ACPI: Fix ThunderX PEM initialization

2017-03-16 Thread David Daney
On 03/16/2017 07:32 AM, Jon Masters wrote: Hi Vadim, Thanks for your followup and attention to this matter. More below. On 03/15/2017 07:33 AM, Vadim Lomovtsev wrote: The upstream Linux kernel contains a quirk matching entry that looks for "THRX". Therefore, you have already agreed (as of at

Re: [PATCH] PCI: ACPI: Fix ThunderX PEM initialization

2017-03-16 Thread Jon Masters
Hi Vadim, Thanks for your followup and attention to this matter. More below. On 03/15/2017 07:33 AM, Vadim Lomovtsev wrote: >> The upstream Linux kernel contains a quirk matching entry that looks for >> "THRX". Therefore, you have already agreed (as of at least January) that >> this is the prefi

Re: [PATCH] PCI: ACPI: Fix ThunderX PEM initialization

2017-03-15 Thread Vadim Lomovtsev
Hi Jon, On Wed, Mar 15, 2017 at 07:14:38AM -0400, Jon Masters wrote: > Hi Bjorn, Vadim, > > Following up to this old thread... > > On 02/01/2017 10:18 AM, Bjorn Helgaas wrote: > > On Wed, Feb 01, 2017 at 04:53:25AM -0800, Vadim Lomovtsev wrote: > > Because there is no such ACPI ID as "THRX

Re: [PATCH] PCI: ACPI: Fix ThunderX PEM initialization

2017-03-15 Thread Jon Masters
Hi Bjorn, Vadim, Following up to this old thread... On 02/01/2017 10:18 AM, Bjorn Helgaas wrote: > On Wed, Feb 01, 2017 at 04:53:25AM -0800, Vadim Lomovtsev wrote: Because there is no such ACPI ID as "THRX0002" registered (http://www.uefi.org/acpi_id_list). There is still no "THRX" pr

Re: [PATCH] PCI: ACPI: Fix ThunderX PEM initialization

2017-02-01 Thread Vadim Lomovtsev
On Wed, Feb 01, 2017 at 09:18:07AM -0600, Bjorn Helgaas wrote: > On Wed, Feb 01, 2017 at 04:53:25AM -0800, Vadim Lomovtsev wrote: > > On Tue, Jan 31, 2017 at 02:31:09PM -0600, Bjorn Helgaas wrote: > > > On Tue, Jan 31, 2017 at 06:57:20AM -0800, Vadim Lomovtsev wrote: > > > > On Tue, Jan 31, 2017 at

Re: [PATCH] PCI: ACPI: Fix ThunderX PEM initialization

2017-02-01 Thread Bjorn Helgaas
On Wed, Feb 01, 2017 at 04:53:25AM -0800, Vadim Lomovtsev wrote: > On Tue, Jan 31, 2017 at 02:31:09PM -0600, Bjorn Helgaas wrote: > > On Tue, Jan 31, 2017 at 06:57:20AM -0800, Vadim Lomovtsev wrote: > > > On Tue, Jan 31, 2017 at 08:25:25AM -0600, Bjorn Helgaas wrote: > > > > On Tue, Jan 31, 2017 at

Re: [PATCH] PCI: ACPI: Fix ThunderX PEM initialization

2017-02-01 Thread Vadim Lomovtsev
On Tue, Jan 31, 2017 at 02:31:09PM -0600, Bjorn Helgaas wrote: > On Tue, Jan 31, 2017 at 06:57:20AM -0800, Vadim Lomovtsev wrote: > > On Tue, Jan 31, 2017 at 08:25:25AM -0600, Bjorn Helgaas wrote: > > > On Tue, Jan 31, 2017 at 02:28:30AM -0800, Vadim Lomovtsev wrote: > > > > Hi Bjorn, > > > > > >

Re: [PATCH] PCI: ACPI: Fix ThunderX PEM initialization

2017-01-31 Thread Bjorn Helgaas
On Tue, Jan 31, 2017 at 06:57:20AM -0800, Vadim Lomovtsev wrote: > On Tue, Jan 31, 2017 at 08:25:25AM -0600, Bjorn Helgaas wrote: > > On Tue, Jan 31, 2017 at 02:28:30AM -0800, Vadim Lomovtsev wrote: > > > Hi Bjorn, > > > > > > On Mon, Jan 30, 2017 at 03:12:37PM -0600, Bjorn Helgaas wrote: > > > >

Re: [PATCH] PCI: ACPI: Fix ThunderX PEM initialization

2017-01-31 Thread Vadim Lomovtsev
On Tue, Jan 31, 2017 at 08:25:25AM -0600, Bjorn Helgaas wrote: > On Tue, Jan 31, 2017 at 02:28:30AM -0800, Vadim Lomovtsev wrote: > > Hi Bjorn, > > > > On Mon, Jan 30, 2017 at 03:12:37PM -0600, Bjorn Helgaas wrote: > > > Hi Vadim, > > > > > > On Mon, Jan 30, 2017 at 08:25:52AM -0800, Vadim Lomovt

Re: [PATCH] PCI: ACPI: Fix ThunderX PEM initialization

2017-01-31 Thread Bjorn Helgaas
On Tue, Jan 31, 2017 at 02:28:30AM -0800, Vadim Lomovtsev wrote: > Hi Bjorn, > > On Mon, Jan 30, 2017 at 03:12:37PM -0600, Bjorn Helgaas wrote: > > Hi Vadim, > > > > On Mon, Jan 30, 2017 at 08:25:52AM -0800, Vadim Lomovtsev wrote: > > > This patch is to address PEM initialization issue > > > whic

Re: [PATCH] PCI: ACPI: Fix ThunderX PEM initialization

2017-01-31 Thread Vadim Lomovtsev
Hi Bjorn, On Mon, Jan 30, 2017 at 03:12:37PM -0600, Bjorn Helgaas wrote: > Hi Vadim, > > On Mon, Jan 30, 2017 at 08:25:52AM -0800, Vadim Lomovtsev wrote: > > This patch is to address PEM initialization issue > > which causes network issues. > > > > It is necessary to search for _HID:PNP0A08 whil

Re: [PATCH] PCI: ACPI: Fix ThunderX PEM initialization

2017-01-30 Thread Bjorn Helgaas
Hi Vadim, On Mon, Jan 30, 2017 at 08:25:52AM -0800, Vadim Lomovtsev wrote: > This patch is to address PEM initialization issue > which causes network issues. > > It is necessary to search for _HID:PNP0A08 while requesting > PEM resources via ACPI instead of "THRX0002". > > Signed-off-by: Vadim L

Re: [PATCH] PCI: ACPI: Fix ThunderX PEM initialization

2017-01-30 Thread David Daney
On 01/30/2017 08:25 AM, Vadim Lomovtsev wrote: This patch is to address PEM initialization issue which causes network issues. It is necessary to search for _HID:PNP0A08 while requesting PEM resources via ACPI instead of "THRX0002". Since this is fixing new code, there should be no chance to br