Re: [PATCH] PCI: nVidia's MCP61 ethernet card needs quirk for wrong class

2007-10-01 Thread Greg KH
On Mon, Oct 01, 2007 at 11:03:38AM -0600, Matthew Wilcox wrote: > On Mon, Oct 01, 2007 at 09:25:46AM -0700, Greg KH wrote: > > For config items, we don't want to modify them in any way, we just want > > to pass-through the data direct from the device. Look at the sysfs and > > proc files for pci c

Re: [PATCH] PCI: nVidia's MCP61 ethernet card needs quirk for wrong class

2007-10-01 Thread Matthew Wilcox
On Mon, Oct 01, 2007 at 09:25:46AM -0700, Greg KH wrote: > I'll defer to Jeff's judgement here. If the device is broken such that > it does not know to return the correct class, then we need to be able to > have a "quirk" table in the userspace tools to handle the list of > devices that are broken

Re: [PATCH] PCI: nVidia's MCP61 ethernet card needs quirk for wrong class

2007-10-01 Thread Greg KH
On Mon, Oct 01, 2007 at 05:24:37PM +0200, Jiri Kosina wrote: > On Mon, 1 Oct 2007, Jeff Garzik wrote: > > > What would you recommend as a method for userspace to detect whether > > > given hardware is a network card, supposing that there is no driver > > > bound to it yet? > > Note the mention of

Re: [PATCH] PCI: nVidia's MCP61 ethernet card needs quirk for wrong class

2007-10-01 Thread Jiri Kosina
On Mon, 1 Oct 2007, Jeff Garzik wrote: > > > There are other network devices that do not claim > > > PCI_CLASS_NETWORK_ETHERNET either. > > Nor any other PCI_CLASS_NETWORK subclass? > Correct. BTW do you have some examples off the top of your head? > > What would you recommend as a method for u

Re: [PATCH] PCI: nVidia's MCP61 ethernet card needs quirk for wrong class

2007-10-01 Thread Jeff Garzik
Jiri Kosina wrote: On Mon, 1 Oct 2007, Jeff Garzik wrote: There are other network devices that do not claim PCI_CLASS_NETWORK_ETHERNET either. Nor any other PCI_CLASS_NETWORK subclass? Correct. Since this is a purely cosmetic issue -- said userland tools would need to support weird cas

Re: [PATCH] PCI: nVidia's MCP61 ethernet card needs quirk for wrong class

2007-10-01 Thread Jiri Kosina
On Mon, 1 Oct 2007, Jeff Garzik wrote: > There are other network devices that do not claim > PCI_CLASS_NETWORK_ETHERNET either. Nor any other PCI_CLASS_NETWORK subclass? > Since this is a purely cosmetic issue -- said userland tools would need > to support weird cases _anyway_ -- I am not in

Re: [PATCH] PCI: nVidia's MCP61 ethernet card needs quirk for wrong class

2007-10-01 Thread Jeff Garzik
Jiri Kosina wrote: On Mon, 1 Oct 2007, Jeff Garzik wrote: PCI: nVidia's MCP61 ethernet card needs quirk for wrong class The MCP61 ethernet controller from nVidia (NVENET_19) contains wrong PCI class: 00:07.0 Bridge [0680]: nVidia Corporation MCP61 Ethernet [10de:03ef] (rev a2) i.e. it identif

Re: [PATCH] PCI: nVidia's MCP61 ethernet card needs quirk for wrong class

2007-10-01 Thread Jiri Kosina
On Mon, 1 Oct 2007, Jeff Garzik wrote: > > PCI: nVidia's MCP61 ethernet card needs quirk for wrong class > > The MCP61 ethernet controller from nVidia (NVENET_19) contains wrong > > PCI class: > > 00:07.0 Bridge [0680]: nVidia Corporation MCP61 Ethernet [10de:03ef] (rev > > a2) > > i.e. it ident

Re: [PATCH] PCI: nVidia's MCP61 ethernet card needs quirk for wrong class

2007-10-01 Thread Jeff Garzik
Jiri Kosina wrote: From: Jiri Kosina <[EMAIL PROTECTED]> PCI: nVidia's MCP61 ethernet card needs quirk for wrong class The MCP61 ethernet controller from nVidia (NVENET_19) contains wrong PCI class: 00:07.0 Bridge [0680]: nVidia Corporation MCP61 Ethernet [10de:03ef] (rev a2) i.e. it