Re: [PATCH] PCI: rockchip: correct the use of FTS mask

2016-11-14 Thread Bjorn Helgaas
On Tue, Oct 18, 2016 at 04:13:04PM -0700, Brian Norris wrote: > We're trying to mask out bits[23:8] while retaining [32:24, 7:0], but > we're doing the inverse. That doesn't have too much effect, since we're > setting all the [23:8] bits to 1, and the other bits are only relevant > for modes we're

Re: [PATCH] PCI: rockchip: correct the use of FTS mask

2016-11-11 Thread Shawn Lin
On 2016/11/12 6:30, Bjorn Helgaas wrote: On Tue, Oct 18, 2016 at 04:13:04PM -0700, Brian Norris wrote: We're trying to mask out bits[23:8] while retaining [32:24, 7:0], but we're doing the inverse. That doesn't have too much effect, since we're setting all the [23:8] bits to 1, and the other bit

Re: [PATCH] PCI: rockchip: correct the use of FTS mask

2016-11-11 Thread Bjorn Helgaas
On Tue, Oct 18, 2016 at 04:13:04PM -0700, Brian Norris wrote: > We're trying to mask out bits[23:8] while retaining [32:24, 7:0], but > we're doing the inverse. That doesn't have too much effect, since we're > setting all the [23:8] bits to 1, and the other bits are only relevant > for modes we're