Re: [PATCH] PPC: CELLEB - fix potential NULL pointer dereference

2007-11-28 Thread Cyrill Gorcunov
On 11/29/07, Ishizaki Kou <[EMAIL PROTECTED]> wrote: [...snip...] > > There is no problem to use Michael's part, and I also prefer simple > one like this. > > Cyrill, would you please update your patch? > > Best regards, > Kou Ishizaki > Please see updated patch enveloped. (Can't do it inline beca

Re: [PATCH] PPC: CELLEB - fix potential NULL pointer dereference

2007-11-28 Thread Ishizaki Kou
Cyrill Gorcunov <[EMAIL PROTECTED]> wrote: > On 11/28/07, Cyrill Gorcunov <[EMAIL PROTECTED]> wrote: > > On 11/28/07, Michael Ellerman <[EMAIL PROTECTED]> wrote: > > > On Mon, 2007-11-26 at 10:46 +0300, Cyrill Gorcunov wrote: > > > > This patch adds checking for NULL value returned to prevent possi

Re: [PATCH] PPC: CELLEB - fix potential NULL pointer dereference

2007-11-28 Thread Cyrill Gorcunov
On 11/28/07, Cyrill Gorcunov <[EMAIL PROTECTED]> wrote: > On 11/28/07, Michael Ellerman <[EMAIL PROTECTED]> wrote: > > On Mon, 2007-11-26 at 10:46 +0300, Cyrill Gorcunov wrote: > > > This patch adds checking for NULL value returned to prevent possible > > > NULL pointer dereference. > > > Also two

Re: [PATCH] PPC: CELLEB - fix potential NULL pointer dereference

2007-11-28 Thread Cyrill Gorcunov
On 11/28/07, Michael Ellerman <[EMAIL PROTECTED]> wrote: > On Mon, 2007-11-26 at 10:46 +0300, Cyrill Gorcunov wrote: > > This patch adds checking for NULL value returned to prevent possible > > NULL pointer dereference. > > Also two unneeded 'return' are removed. > > > > Signed-off-by: Cyrill Gorcu

Re: [PATCH] PPC: CELLEB - fix potential NULL pointer dereference

2007-11-28 Thread Michael Ellerman
On Mon, 2007-11-26 at 10:46 +0300, Cyrill Gorcunov wrote: > This patch adds checking for NULL value returned to prevent possible > NULL pointer dereference. > Also two unneeded 'return' are removed. > > Signed-off-by: Cyrill Gorcunov <[EMAIL PROTECTED]> > --- > Any comments are welcome. I guess i

Re: [PATCH] PPC: CELLEB - fix potential NULL pointer dereference

2007-11-28 Thread Ishizaki Kou
> This patch adds checking for NULL value returned to prevent possible > NULL pointer dereference. > Also two unneeded 'return' are removed. > > Signed-off-by: Cyrill Gorcunov <[EMAIL PROTECTED]> Thanks, I tested your patch and it works. My original code supposes that the device-tree is provided