Re: [PATCH] PPC64: Generic hotplug cpu support

2005-02-27 Thread Andrew Morton
Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > > - if (cpu_is_offline(smp_processor_id()) && > > + if (cpu_is_offline(_smp_processor_id()) && > >system_state == SYSTEM_RUNNING) > >cpu_die(); > >} > > _ > > This is the idle loo

Re: [PATCH] PPC64: Generic hotplug cpu support

2005-02-27 Thread Benjamin Herrenschmidt
On Sun, 2005-02-27 at 03:16 -0800, Andrew Morton wrote: > Zwane Mwaikambo <[EMAIL PROTECTED]> wrote: > > > > Patch provides a generic hotplug cpu implementation, with the only current > > user being pmac. > > BUG: using smp_processor_id() in preemptible [0001] code: swapper/0 > caller is .na

Re: [PATCH] PPC64: Generic hotplug cpu support

2005-02-27 Thread Andrew Morton
Zwane Mwaikambo <[EMAIL PROTECTED]> wrote: > > Patch provides a generic hotplug cpu implementation, with the only current > user being pmac. BUG: using smp_processor_id() in preemptible [0001] code: swapper/0 caller is .native_idle+0x30/0x60 --- 25/arch/ppc64/kernel/idle.c~ppc64-generic-hot