Re: [PATCH] RFC: leds-pwm: don't disable pwm when setting brightness to 0

2013-01-04 Thread Sascha Hauer
On Thu, Jan 03, 2013 at 10:01:18AM +0100, Thierry Reding wrote: > On Thu, Oct 25, 2012 at 04:03:49PM +0800, Shawn Guo wrote: > > On Wed, Oct 24, 2012 at 03:52:46PM +0200, Uwe Kleine-König wrote: > > > This fixes disabling the LED on i.MX28. The PWM hardware delays using > > > the newly set pwm-conf

Re: [PATCH] RFC: leds-pwm: don't disable pwm when setting brightness to 0

2013-01-03 Thread Thierry Reding
On Thu, Jan 03, 2013 at 09:55:14PM +0100, Uwe Kleine-König wrote: > Hi Thierry, > > On Thu, Jan 03, 2013 at 10:01:18AM +0100, Thierry Reding wrote: > > On Thu, Oct 25, 2012 at 04:03:49PM +0800, Shawn Guo wrote: > > > On Wed, Oct 24, 2012 at 03:52:46PM +0200, Uwe Kleine-König wrote: > > > > This fi

Re: [PATCH] RFC: leds-pwm: don't disable pwm when setting brightness to 0

2013-01-03 Thread Uwe Kleine-König
Hi Thierry, On Thu, Jan 03, 2013 at 10:01:18AM +0100, Thierry Reding wrote: > On Thu, Oct 25, 2012 at 04:03:49PM +0800, Shawn Guo wrote: > > On Wed, Oct 24, 2012 at 03:52:46PM +0200, Uwe Kleine-König wrote: > > > This fixes disabling the LED on i.MX28. The PWM hardware delays using > > > the newly

Re: [PATCH] RFC: leds-pwm: don't disable pwm when setting brightness to 0

2013-01-03 Thread Thierry Reding
On Thu, Oct 25, 2012 at 04:03:49PM +0800, Shawn Guo wrote: > On Wed, Oct 24, 2012 at 03:52:46PM +0200, Uwe Kleine-König wrote: > > This fixes disabling the LED on i.MX28. The PWM hardware delays using > > the newly set pwm-config until the beginning of a new period. It's very > > likely that pwm_d

Re: [PATCH] RFC: leds-pwm: don't disable pwm when setting brightness to 0

2012-10-25 Thread Shawn Guo
On Wed, Oct 24, 2012 at 03:52:46PM +0200, Uwe Kleine-König wrote: > This fixes disabling the LED on i.MX28. The PWM hardware delays using > the newly set pwm-config until the beginning of a new period. It's very > likely that pwm_disable is called before the current period ends. In > case the LED